DialysateGenerator.py

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED

RESOLVED

Dialin Review
Dialin Review
RESOLVED

RESOLVED

DIALIN-ACK
DIALIN-ACK
DIALIN Staging Unreviewed Commits
DIALIN Staging Unreviewed Commits
RESOLVED.

RESOLVED.

This code has been modified since.

This code has been modified since.

I would keep bytearray as one word since it's a python type .

I would keep bytearray as one word since it's a python type .

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Requested changes are now added

Requested changes are now added

For now, I've updated them here manually (see latest changes)

For now, I've updated them here manually (see latest changes)

Requested changes are now added

Requested changes are now added

This script has only been moved or renamed, as I am not the original author. In this section, it appears to just be emitting a dummy payload to the DG sync broadcast channel id every second. I don'...

This script has only been moved or renamed, as I am not the original author.
In this section, it appears to just be emitting a dummy payload to the DG sync broadcast channel id every second. I don't see how it could interfere with other messages being sent on the CAN bus since it is just adding a little traffic to the bus once every second. The type of other nodes on the bus shouldn't matter.

No, I think we need to separate them, potentially putting them in a different repository altogether in the future To avoid deleting people's work, I didn't delete test scripts in this commit. In f...

No, I think we need to separate them, potentially putting them in a different repository altogether in the future

To avoid deleting people's work, I didn't delete test scripts in this commit. In future commits, I will reach out to people and let them know before they are deleted or moved

Generally speaking, do we want to have a mix of Dialin API code and Python test scripts?

Generally speaking, do we want to have a mix of Dialin API code and Python test scripts?