hd_valves_test.py

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DIALIN-DENBUG-280_Issues With HD Broadcast P1
DIALIN-DENBUG-280_Issues With HD Broadcast P1
DIALIN-DENBUG-280_Issues With HD Broadcast P1B
DIALIN-DENBUG-280_Issues With HD Broadcast P1B
This CR should be closed due to bad branching. Should have been branched out of p1_staging.

This CR should be closed due to bad branching. Should have been branched out of p1_staging.

DIALIN-DIAL-299_Air Trap Observer NO Longer Pub P1
DIALIN-DIAL-299_Air Trap Observer NO Longer Pub P1
RESOLVED

RESOLVED

DIALIN-DEN-2652_DG Valve Control 1 of 2
DIALIN-DEN-2652_DG Valve Control 1 of 2
RESOLVED.

RESOLVED.

This variable was very temporary. I deleted it.

This variable was very temporary. I deleted it.

I don't have an issue with temporary features or variables being merged into staging but could we not name them so vaguely? Ex: calc_rpm_start_time_removable or calc_rpm_start_time_temporary?

I don't have an issue with temporary features or variables being merged into staging but could we not name them so vaguely? Ex: calc_rpm_start_time_removable or calc_rpm_start_time_temporary?

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

I made it like HD.

I made it like HD.

Done.

Done.

Agreed. I will clean them up gradually. Removed the commented code.

Agreed. I will clean them up gradually. Removed the commented code.

Done.

Done.

This class is used to wait for the results to be received from firmware. I fixed the order.

This class is used to wait for the results to be received from firmware. I fixed the order.