Activity hdfirmware/results/cppcheck.log

9:23 am

Sean Nash

More
HD-DEN-16446-2
finished reviewing

4:37 pm

wbracken (deleted user)

More
HD-DEN-16446-2
finished reviewing

4:36 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

2:23 pm

Dara Navaei

More
Re: HD-DEN-16446-2
replied to wbracken (deleted user)

The result will be an unsigned integer

2:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

1:37 pm

Vinayakam Mani

More
Re: HD-DEN-16446-2
replied to Sean Nash

In the If conditions, we check "uFVolume > colUFVol" conditions, that makes uFRate always positive and hence the condition for minimum check is not required.

9:33 am

Dara Navaei

More
Re: HD-DEN-1312-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH

9:31 am

Dara Navaei

More
HD-DEN-1312-1
resumed reviewing

9:31 am

Dara Navaei

More
HD-DEN-1312-1
started review

HD-DEN-1312_HD Dialysate Inlet Pump/Drive, Flow Sensor, Control

8:57 am

Dara Navaei

More
Re: HD-DEN-431-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH

8:53 am

Dara Navaei

More
HD-DEN-431-1
started review

HD-DEN-431_Real Time Clock

3:00 pm

jtaylor (deleted user)

More
HD-DEN-16446-2
resumed reviewing

11:05 am

Sean Nash

More
Re: HD-DEN-16446-2
commented on review

I think we need the minimum check too. uFRate can be negative if user sets volume to something lower than what has already been collected (negative volume) which would yield a negative rate which i...

I think we need the minimum check too. uFRate can be negative if user sets volume to something lower than what has already been collected (negative volume) which would yield a negative rate which is < 0.0.

10:42 am