leahi-common

Clone Tools

Stats

Commits this week: 17
Total Committers: 19
Last Commit: 17:28
Commits this week: 17

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
4 hrs ago

Vendor - TEL - Varshini Nagabooshanam

LDT-4033-patient-vitals-fw-implementation

Options
    • -4
    • +0
    /AlarmDefs.h
5 hrs ago

Sean Nash

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

5 hrs ago

Sean Nash

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

5 hrs ago

Sean Nash

Use OVERRIDE_RESET for .override instead of 0.

Use OVERRIDE_RESET for .override instead of 0.

6 hrs ago

Vendor - TEL - Arpita Srivastava

We can rename priorState to previousInstallState. Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

6 hrs ago

Sean Nash and Vendor - TEL - Arpita Srivastava

6 hrs ago

Sean Nash

SW fault here?

SW fault here?

6 hrs ago

Sean Nash

Do we need this state if all it's doing is going to IDLE?

Do we need this state if all it's doing is going to IDLE?

6 hrs ago

Sean Nash

Might have to wait for module to not be busy before getting the data.

Might have to wait for module to not be busy before getting the data.

7 hrs ago

Sean Nash

I think we may need to give a get data command here.

I think we may need to give a get data command here.

7 hrs ago

Sean Nash

Look for request flag to give measure command and transition to measure state.

Look for request flag to give measure command and transition to measure state.

7 hrs ago

Sean Nash

Write private handle functions for each state and call them in each case.

Write private handle functions for each state and call them in each case.

7 hrs ago

Sean Nash

Should we also check whether bpMeasurementReady is TRUE?

Should we also check whether bpMeasurementReady is TRUE?

7 hrs ago

Sean Nash

Same.

Same.

7 hrs ago

Sean Nash

Same. Set a request flag to TRUE (for Peds this time) and let the state machine do the rest.

Same. Set a request flag to TRUE (for Peds this time) and let the state machine do the rest.

7 hrs ago

Sean Nash

Don't change state from outside signal. We should just set a requestBPMeasurement flag to TRUE in this function (if current state is IDLE) and then when the state machine runs next, the IDLE state ...

Don't change state from outside signal. We should just set a requestBPMeasurement flag to TRUE in this function (if current state is IDLE) and then when the state machine runs next, the IDLE state should look for this flag to be TRUE and transition to MEASURE state (by doing all of these things you have here in this function).

7 hrs ago

Sean Nash

Change comment to "Number of BP driver states."

Change comment to "Number of BP driver states."

7 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Not really, I can change this to private

Not really, I can change this to private

7 hrs ago

Sean Nash

Add a 5th enum for NUM_OF_BP_DRIVER_STATES. And, does this need to be public?

Add a 5th enum for NUM_OF_BP_DRIVER_STATES.
And, does this need to be public?

8 hrs ago

Vendor - TEL - Jashwant Gantyada

align indentation, same for line 338 as well.

align indentation, same for line 338 as well.

8 hrs ago

Vendor - TEL - Arpita Srivastava

Yes. Otherwise, we will have to hard code the calibration record for the time being.

Yes.
Otherwise, we will have to hard code the calibration record for the time being.

8 hrs ago

Vendor - TEL - Arpita Srivastava

The function getSoftwareConfigStatus() is also part of NVM module. Moreover, we are planning to remove this function when NVM will be implemented. So, we will have to perform a cleanup and remove a...

The function getSoftwareConfigStatus() is also part of NVM module.
Moreover, we are planning to remove this function when NVM will be implemented.
So, we will have to perform a cleanup and remove all similar calls that have been currently commented out in other files as well like AirTrap.c, BloodFlow.c, etc.

8 hrs ago

Sean Nash

if syrPumpDACControl is U16 (2 bytes), then nibpCtl should be at 42.

if syrPumpDACControl is U16 (2 bytes), then nibpCtl should be at 42.

8 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

9 hrs ago

Vendor - TEL - Varshini Nagabooshanam

LDT-4033-patient-vitals-fw-implementation

Options
    • -0
    • +24
    /AlarmDefs.h
10 hrs ago

Sean Nash

Is this the right time to zero this volume?

Is this the right time to zero this volume?

10 hrs ago

Sean Nash

update total volume too?

update total volume too?

10 hrs ago

Sean Nash

maybe use target rate for both.

maybe use target rate for both.

10 hrs ago

Sean Nash

Use #define for array size.

Use #define for array size.

10 hrs ago

Sean Nash

Make the 6 a #define

Make the 6 a #define