leahi-common

Clone Tools

Stats

Commits this week: 21
Total Committers: 19
Last Commit: 13:33
Commits this week: 21

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Added comments

Options
    • -7
    • +60
    /AlarmDefs.h
    • -3
    • +15
    /MsgDefs.h
    • -22
    • +25
    /TDDefs.h
2 hrs ago

Sean Nash

Do we not need the module error alarm?

Do we not need the module error alarm?

2 hrs ago

Sean Nash

This is not an atomic assignment, so we have to consider thread safety. If this driver is running from General Task (I believe it is since ModeTreatment's exec will be calling the BPModule's exec w...

This is not an atomic assignment, so we have to consider thread safety.
If this driver is running from General Task (I believe it is since ModeTreatment's exec will be calling the BPModule's exec which calls this driver's exec) and if the caller to this function will also be running from General Task (I believe it is since BPModule controller is the caller), then there is no thread safety issue and we should mention in the function header brief that this function should only be called from within the General Task.
If another task is involved (e.g. Priority Task is calling this function), this function could be interrupting the get data state while it is populating bpResults with new results and the caller would get a mix of old and new results (we would not want that).

2 hrs ago

Sean Nash and Vendor - TEL - Jashwant Gantyada

2 hrs ago

Vendor - TEL - Varshini Nagabooshanam

LDT-3215-measured-venous-pressure-decreases

Options
    • -44
    • +184
    /AlarmDefs.h
2 hrs ago

Sean Nash

same.

same.

2 hrs ago

Sean Nash

same.

same.

2 hrs ago

Sean Nash

Just like driver state machine, we should only set a request flag to TRUE here and let the state machine handle the transition.

Just like driver state machine, we should only set a request flag to TRUE here and let the state machine handle the transition.

2 hrs ago

Sean Nash

How do we get out of Idle state?

How do we get out of Idle state?

2 hrs ago

Sean Nash

This should be called in all states (so in controller's exec function).

This should be called in all states (so in controller's exec function).

2 hrs ago

Sean Nash

I don't think we want to zero this count here.

I don't think we want to zero this count here.

2 hrs ago

Sean Nash

We need to call the driver exec function from this exec function - either before or after the switch statement.

We need to call the driver exec function from this exec function - either before or after the switch statement.

2 hrs ago

Sean Nash

We need to call this from ModeTreatment transition function.

We need to call this from ModeTreatment transition function.

2 hrs ago

Sean Nash

We need to call this function from ModeTreatment exec function.

We need to call this function from ModeTreatment exec function.

2 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

2 hrs ago

Sean Nash

s/w fault needs alarm data. See other examples.

s/w fault needs alarm data. See other examples.

2 hrs ago

Sean Nash

Why do you have { here?

Why do you have { here?

3 hrs ago

Sean Nash

For init function, just say "BPModule variables initialized."

For init function, just say "BPModule variables initialized."

3 hrs ago

Sean Nash

The driver has one of these too. Does the controller need to store the results when it can ask the driver for them?

The driver has one of these too. Does the controller need to store the results when it can ask the driver for them?

3 hrs ago

Sean Nash

I'm not sure we need these "Detected" functions. I would expect that when this controller gets new readings, it will check for these alarm conditions in the check state and trigger alarm if appropr...

I'm not sure we need these "Detected" functions. I would expect that when this controller gets new readings, it will check for these alarm conditions in the check state and trigger alarm if appropriate. So if we are triggering alarms in this controller, there is no need for outside code to ask if these alarms are detected.

3 hrs ago

Sean Nash

I think these will eventually be coming from institutional settings, so maybe put a TODO comment to remove these when institutional settings are available.

I think these will eventually be coming from institutional settings, so maybe put a TODO comment to remove these when institutional settings are available.

3 hrs ago

Sean Nash

Is this all we need to look at to know that measurement is done? Do we need to look at busy status?

Is this all we need to look at to know that measurement is done? Do we need to look at busy status?

3 hrs ago

Sean Nash

Move this function down a bit. Init function should be first.

Move this function down a bit. Init function should be first.

3 hrs ago

Sean Nash

Typically, we would have state handle function return "next state" instead of changing the state directly.

Typically, we would have state handle function return "next state" instead of changing the state directly.

3 hrs ago

Sean Nash

That looks like an fpga function, not an input.

That looks like an fpga function, not an input.

3 hrs ago

Sean Nash

Looks like you removed error state, so we should remove it here too.

Looks like you removed error state, so we should remove it here too.

3 hrs ago

Sean Nash

See other switch statements with s/w faults to see how to trigger it. We need 2 data: 1 is specific s/w fault enum and 2 is the invalid state.

See other switch statements with s/w faults to see how to trigger it. We need 2 data: 1 is specific s/w fault enum and 2 is the invalid state.

3 hrs ago

Sean Nash

For init function, just say "BPDriver variables initialized."

For init function, just say "BPDriver variables initialized."

3 hrs ago

Sean Nash

Initialize bpResults and new flags.

Initialize bpResults and new flags.

Wednesday 20 May
5:32 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added