leahi-common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 22
Total Committers: 15
Last Commit: 22 May
Commits this week: 22

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 20 May
5:28 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-4033-patient-vitals-fw-implementation

Options
    • -4
    • +0
    /AlarmDefs.h
4:23 pm

Sean Nash

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

4:22 pm

Sean Nash

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

4:20 pm

Sean Nash

Use OVERRIDE_RESET for .override instead of 0.

Use OVERRIDE_RESET for .override instead of 0.

3:49 pm

Vendor - TEL - Arpita Srivastava

We can rename priorState to previousInstallState. Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

3:19 pm

Sean Nash

SW fault here?

SW fault here?

3:19 pm

Sean Nash

Do we need this state if all it's doing is going to IDLE?

Do we need this state if all it's doing is going to IDLE?

3:18 pm

Sean Nash

Might have to wait for module to not be busy before getting the data.

Might have to wait for module to not be busy before getting the data.

3:16 pm

Sean Nash

I think we may need to give a get data command here.

I think we may need to give a get data command here.

3:15 pm

Sean Nash

Look for request flag to give measure command and transition to measure state.

Look for request flag to give measure command and transition to measure state.

3:14 pm

Sean Nash

Write private handle functions for each state and call them in each case.

Write private handle functions for each state and call them in each case.

3:13 pm

Sean Nash

Should we also check whether bpMeasurementReady is TRUE?

Should we also check whether bpMeasurementReady is TRUE?

3:12 pm

Sean Nash

Same.

Same.

3:12 pm

Sean Nash

Same. Set a request flag to TRUE (for Peds this time) and let the state machine do the rest.

Same. Set a request flag to TRUE (for Peds this time) and let the state machine do the rest.

3:11 pm

Sean Nash

Don't change state from outside signal. We should just set a requestBPMeasurement flag to TRUE in this function (if current state is IDLE) and then when the state machine runs next, the IDLE state ...

Don't change state from outside signal. We should just set a requestBPMeasurement flag to TRUE in this function (if current state is IDLE) and then when the state machine runs next, the IDLE state should look for this flag to be TRUE and transition to MEASURE state (by doing all of these things you have here in this function).

3:07 pm

Sean Nash

Change comment to "Number of BP driver states."

Change comment to "Number of BP driver states."

2:50 pm

Vendor - TEL - Varshini Nagabooshanam

Not really, I can change this to private

Not really, I can change this to private

2:42 pm

Sean Nash

Add a 5th enum for NUM_OF_BP_DRIVER_STATES. And, does this need to be public?

Add a 5th enum for NUM_OF_BP_DRIVER_STATES.
And, does this need to be public?

2:12 pm

Vendor - TEL - Jashwant Gantyada

align indentation, same for line 338 as well.

align indentation, same for line 338 as well.

2:07 pm

Vendor - TEL - Arpita Srivastava

Yes. Otherwise, we will have to hard code the calibration record for the time being.

Yes.
Otherwise, we will have to hard code the calibration record for the time being.

1:59 pm

Vendor - TEL - Arpita Srivastava

The function getSoftwareConfigStatus() is also part of NVM module. Moreover, we are planning to remove this function when NVM will be implemented. So, we will have to perform a cleanup and remove a...

The function getSoftwareConfigStatus() is also part of NVM module.
Moreover, we are planning to remove this function when NVM will be implemented.
So, we will have to perform a cleanup and remove all similar calls that have been currently commented out in other files as well like AirTrap.c, BloodFlow.c, etc.

1:26 pm

Sean Nash

if syrPumpDACControl is U16 (2 bytes), then nibpCtl should be at 42.

if syrPumpDACControl is U16 (2 bytes), then nibpCtl should be at 42.

1:23 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:00 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-4033-patient-vitals-fw-implementation

Options
    • -0
    • +24
    /AlarmDefs.h
12:14 pm

Sean Nash

Is this the right time to zero this volume?

Is this the right time to zero this volume?

12:13 pm

Sean Nash

update total volume too?

update total volume too?

12:09 pm

Sean Nash

maybe use target rate for both.

maybe use target rate for both.

11:41 am

Sean Nash

Use #define for array size.

Use #define for array size.

11:40 am

Sean Nash

Make the 6 a #define

Make the 6 a #define

11:39 am

Sean Nash

only 1 return statement

only 1 return statement