leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 15
Last Commit: 02 Mar
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 27 Feb
11:57 am

Vendor - TEL - Varshini Nagabooshanam

LDT-3126-blood-prime-td

Options
    • -0
    • +1
    /MsgDefs.h
Thursday 26 Feb
11:24 pm

Sean Nash

Response payload is not U08. I believe UI will be expecting a payload of type UI_RESPONSE_PAYLOAD_T (defined in Messaging.h). Verify with Nico that this is the payload he is expecting in response. ...

Response payload is not U08. I believe UI will be expecting a payload of type UI_RESPONSE_PAYLOAD_T (defined in Messaging.h). Verify with Nico that this is the payload he is expecting in response. See signalPauseResumeUF() function for example of how to respond to a UI request.

11:24 pm

Sean Nash

Same comment as other message handling function. Use correct payload type. See signalPauseResumeUF() function for example of how to respond to a UI request.

Same comment as other message handling function. Use correct payload type. See signalPauseResumeUF() function for example of how to respond to a UI request.

11:19 pm

Sean Nash

Why do we need this local variable when we have the static requestedBloodFlowRate_mL_min variable?

Why do we need this local variable when we have the static requestedBloodFlowRate_mL_min variable?

11:18 pm

Sean Nash

Add a blank line after declarations.

Add a blank line after declarations.

11:18 pm

Sean Nash

I would say "TRUE if request is accepted, FALSE if rejected."

I would say "TRUE if request is accepted, FALSE if rejected."

11:16 pm

Sean Nash

I would say "TRUE if request is accepted, FALSE if rejected."

I would say "TRUE if request is accepted, FALSE if rejected."

11:11 pm

Sean Nash

We do not always want to return to run state. If we were in ramp state prior to pause state, we would want to go back to ramp state here. So you need to remember your previous state in a new variable.

We do not always want to return to run state. If we were in ramp state prior to pause state, we would want to go back to ramp state here.
So you need to remember your previous state in a new variable.

11:08 pm

Sean Nash

We do not need to set result here since it is already set to run state at top of this function.

We do not need to set result here since it is already set to run state at top of this function.

11:07 pm

Sean Nash

Remove TODO comment since you have done it.

Remove TODO comment since you have done it.

11:06 pm

Sean Nash

Still need to close valves.

Still need to close valves.

11:06 pm

Sean Nash

Use getTargetBloodFlowRate() instead.

Use getTargetBloodFlowRate() instead.

11:05 pm

Sean Nash

Remove TODO comment since you have done it.

Remove TODO comment since you have done it.

11:04 pm

Sean Nash

Why assign requested rate to ramp rate? Why not just use requested rate in the set function below?

Why assign requested rate to ramp rate? Why not just use requested rate in the set function below?

11:03 pm

Sean Nash

I think we actually should be getting commanded blood flow rate here (getTargetBloodFlowRate) instead of measured rate.

I think we actually should be getting commanded blood flow rate here (getTargetBloodFlowRate) instead of measured rate.

10:58 pm

Sean Nash

Let's go ahead and do this.

Let's go ahead and do this.

10:57 pm

Sean Nash

Let's add a TODO comment so we don't forget to uncomment this when syringe pump is implemented.

Let's add a TODO comment so we don't forget to uncomment this when syringe pump is implemented.

10:55 pm

Sean Nash

Should be only one blank line here.

Should be only one blank line here.

10:55 pm

Sean Nash

I would expect there to be a change to Messaging.c (to add association between msg ID to this new function to the look-up table), but I don't see it.

I would expect there to be a change to Messaging.c (to add association between msg ID to this new function to the look-up table), but I don't see it.

Wednesday 25 Feb
9:24 am

Sean Nash

Why NUM_OF_?

Why NUM_OF_?

9:23 am

Sean Nash

Variable name suggests it is an action/cmd from UI. Comment suggests it is the number of actions. Which is it? And we should initialize in the init function - not here.

Variable name suggests it is an action/cmd from UI. Comment suggests it is the number of actions. Which is it?
And we should initialize in the init function - not here.

9:22 am

Sean Nash

Is this really a timer counter? Looks like a flow rate.

Is this really a timer counter? Looks like a flow rate.

9:19 am

Sean Nash

9:04 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

9:04 am

Vendor - TEL - Varshini Nagabooshanam

Added back

Added back

9:04 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

Monday 23 Feb
1:04 pm

Sean Nash

Add spaces inside of ().

Add spaces inside of ().

1:03 pm

Sean Nash

Stop button is a "hard" pause which would take us to Treatment: Paused state (out of blood prime completely). We want to go to our internal paused state when UI sends us a "soft" blood prime pause ...

Stop button is a "hard" pause which would take us to Treatment: Paused state (out of blood prime completely).
We want to go to our internal paused state when UI sends us a "soft" blood prime pause commands message.

1:01 pm

Sean Nash

Remove blank line.

Remove blank line.

1:00 pm

Sean Nash

Should we add this test config? Systems team will likely want it eventually since they wanted it in Denali.

Should we add this test config? Systems team will likely want it eventually since they wanted it in Denali.