leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 15
Total Committers: 18
Last Commit: 13 Aug
Commits this week: 15

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 04 Aug
10:52 am

Vendor - TEL - Arpita Srivastava

use FALSE

use FALSE

10:52 am

Vendor - TEL - Arpita Srivastava

use FALSE

use FALSE

10:39 am

Vendor - TEL - Arpita Srivastava

It looks like the rows may be misaligned with the alarm ID declarations. For example, ALARM_ID_TD_BATTERY_CHARGER_ERROR_DETECTED is declared as 204.

It looks like the rows may be misaligned with the alarm ID declarations.
For example, ALARM_ID_TD_BATTERY_CHARGER_ERROR_DETECTED is declared as 204.

10:13 am

Vendor - TEL - Arpita Srivastava

When we send any message to UI, usually add the message id in the doxygen header like this. @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the function s...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

  • @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE


Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

  • @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE


Please refer to the function sendTreatmentParamsResponse()

9:55 am

Vendor - TEL - Arpita Srivastava

It looks like the rows may be misaligned with the alarm ID declarations. For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

It looks like the rows may be misaligned with the alarm ID declarations.
For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

9:53 am

Vendor - TEL - Arpita Srivastava

Should Instructions part be this? A problem was detected with the hemodialysis device.

Should Instructions part be this?

A problem was detected with the hemodialysis device.

9:50 am

Vendor - TEL - Arpita Srivastava

Please confirm if the source is DD?

Please confirm if the source is DD?

Friday 31 Jul
11:10 am

Vendor - TEL - Arpita Srivastava

While you are updating this file, can please break this line?

While you are updating this file, can please break this line?

11:08 am

Vendor - TEL - Arpita Srivastava

Can we align like this result = u32BroadcastIntervalOverride( message, &preTreatmentStatePublishInterval, TASK_GENERAL_INTERVAL );

Can we align like this
result = u32BroadcastIntervalOverride( message,
&preTreatmentStatePublishInterval,
TASK_GENERAL_INTERVAL );

11:07 am

Vendor - TEL - Arpita Srivastava

Add to inputs: preTreatmentStatePublishInterval

Add to inputs: preTreatmentStatePublishInterval

10:24 am

Vendor - TEL - Arpita Srivastava

and break the line

and break the line

10:24 am

Vendor - TEL - Arpita Srivastava

assign result to a variable and then return and break the line

assign result to a variable and then return and break the line

10:23 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

10:22 am

Vendor - TEL - Arpita Srivastava

input is none

input is none

10:21 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

10:21 am

Vendor - TEL - Arpita Srivastava

assign this to a variable and then return the variable. break this line

assign this to a variable and then return the variable.

break this line

10:20 am

Vendor - TEL - Arpita Srivastava

Can we align = from line 270 to 281?

Can we align = from line 270 to 281?

10:19 am

Vendor - TEL - Arpita Srivastava

break lines of this function to match our standard of 100 columns.

break lines of this function to match our standard of 100 columns.

10:19 am

Vendor - TEL - Arpita Srivastava

break lines of this function to match our standard of 100 columns.

break lines of this function to match our standard of 100 columns.

10:15 am

Vendor - TEL - Arpita Srivastava

input is none

input is none

10:08 am

Vendor - TEL - Arpita Srivastava

can we define this as NUM_OF_BATTERY_REGISTERS = BATTERY_END_OF_LIST_TIME_TO_PUBLISH, and use NUM_OF_BATTERY_REGISTERS everywhere instead of using [ NUM_OF_BATTERY_REGISTERS - 1 ]

can we define this as NUM_OF_BATTERY_REGISTERS = BATTERY_END_OF_LIST_TIME_TO_PUBLISH,

and use NUM_OF_BATTERY_REGISTERS everywhere instead of using [ NUM_OF_BATTERY_REGISTERS - 1 ]

10:03 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

10:02 am

Vendor - TEL - Arpita Srivastava

Add Comments for line 43 to 50 and align all the comments of this section to line 38.

Add Comments for line 43 to 50 and align all the comments of this section to line 38.

10:00 am

Vendor - TEL - Arpita Srivastava

add a blank line above

add a blank line above

9:59 am

Vendor - TEL - Arpita Srivastava

add a blank line above

add a blank line above

9:56 am

Vendor - TEL - Arpita Srivastava

Add space in [registerSel]

Add space in [registerSel]

9:56 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

9:55 am

Vendor - TEL - Arpita Srivastava

add a blank line above

add a blank line above