leahi-dialin

Clone Tools

Stats

Commits this week: 15
Total Committers: 16
Last Commit: 09:59
Commits this week: 15

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 30 Jun
4:56 pm

Behrouz NematiPour

Merge branch 'feature/LDT-4787-enhancement-power-off' into staging

Options
4:28 pm

Behrouz NematiPour

Merge branch 'feature/LDT-4747-fp-diagnostics' into staging

Options
2:57 pm

Vinayakam Mani

Priority data type is U08?

Priority data type is U08?

Monday 29 Jun
6:26 pm

Sean Nash

6:25 pm

Sean Nash

5:44 pm

Zoltan Miskolci

updated

Options
    • -2
    • +5
    /leahi_dialin/dd/modules/records.py
5:39 pm

Zoltan Miskolci

Fix

Options
    • -2
    • +2
    /leahi_dialin/dd/modules/records.py
5:22 pm

Zoltan Miskolci

Renamed msg ids

Options
    • -31
    • +27
    /leahi_dialin/common/msg_ids.py
    • -31
    • +139
    /leahi_dialin/dd/modules/records.py
2:25 pm

Nicholas Ramirez

LDT-4795 NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I - 08: DEV - Dialin Implementation

fix msg id

Options
    • -1
    • +1
    /leahi_dialin/common/msg_ids.py
2:19 pm

Nicholas Ramirez

Merge remote-tracking branch 'origin/staging' into feature/LDT-4787-enhancement-power-off

Options
    • -1
    • +5
    /leahi_dialin/common/msg_ids.py
2:19 pm

Nicholas Ramirez

added name to freed up mesg id

added name to freed up mesg id

2:19 pm

Nicholas Ramirez

updated

updated

2:19 pm

Nicholas Ramirez

LDT-4795 NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I - 08: DEV - Dialin Implementation

address cr commetns

Options
    • -1
    • +1
    /leahi_dialin/common/msg_ids.py
    • -1
    • +1
    /leahi_dialin/ui/td_messaging.py
12:30 pm

Zoltan Miskolci

Merge branch 'staging' into LDT-3735-non-volatile-memory

Options
    • -2
    • +27
    /leahi_dialin/common/dd_defs.py
    • -0
    • +1
    /leahi_dialin/common/dd_defs_proxy.py
    • -8
    • +35
    /leahi_dialin/common/msg_ids.py
    • -30
    • +2
    /leahi_dialin/dd/dialysate_delivery.py
    • -10
    • +14
    /leahi_dialin/td/treatment_delivery.py
12:28 pm

Zoltan Miskolci

12:24 pm

Zoltan Miskolci

Merge branch 'LDT-4878-buildsh' into staging

Options
12:24 pm

Zoltan Miskolci

Merge branch 'LDT-4539-event_on_service_change' into staging

Options
    • -2
    • +12
    /leahi_dialin/common/dd_defs.py
12:24 pm

Zoltan Miskolci

Merge branch 'LDT-4160-alarm_table' into staging

Options
    • -0
    • +2
    /leahi_dialin/common/msg_ids.py
    • -2
    • +2
    /leahi_dialin/utils/abstract_classes.py
11:29 am

Zoltan Miskolci

Merge branch 'LDT-4539-event_on_service_change' into develop

Options
    • -2
    • +12
    /leahi_dialin/common/dd_defs.py
11:26 am

Zoltan Miskolci

Merge branch 'LDT-4160-alarm_table' into develop

Options
    • -0
    • +2
    /leahi_dialin/common/msg_ids.py
    • -42
    • +109
    /leahi_dialin/td/modules/alarms.py
    • -2
    • +2
    /leahi_dialin/utils/abstract_classes.py
11:23 am

Zoltan Miskolci

Merge branch 'LDT-4878-buildsh' into develop

Options
11:20 am

Zoltan Miskolci

Updated build.sh

Options
    • -6
    • +13
    /build.sh
11:01 am

Dara Navaei

LEAHI-DIALIN-LDT-4878_(Dialin) The wheel file generated by the build.sh command failed to install
LEAHI-DIALIN-LDT-4878_(Dialin) The wheel file generated by the build.sh command failed to install
10:50 am

Michael Garthwaite

10:44 am

Zoltan Miskolci

fixed indexing for eventlist enum

Options
    • -6
    • +6
    /leahi_dialin/common/dd_defs.py
10:42 am

Zoltan Miskolci

docu header

Options
    • -0
    • +3
    /leahi_dialin/td/modules/alarms.py
9:44 am

Zoltan Miskolci

Being generic is the whole point of it. It was renamed because this is a dialin dedicated to Leahi unit and calling the messages DenaliMessage is misleading. It was renamed to CanMessage for 2 reas...

Being generic is the whole point of it.
It was renamed because this is a dialin dedicated to Leahi unit and calling the messages DenaliMessage is misleading.
It was renamed to CanMessage for 2 reason:
1. This is a Leahi only dialin, so there is no need to differentiate between different type of Can Messages as there would be only 1 type
2. Calling it CanMessage will make it more future compatible when the dialin get copied over for a new unit development (unlikely in the foreseeable future but possible), removing the need to rename it again

9:43 am

Zoltan Miskolci

There is no Leahi or Denali CANChannels. There are CAN channels and the naming is what that channel is being used for. The collision occurs in the FW and the FW handles it before sending out a mess...

There is no Leahi or Denali CANChannels.
There are CAN channels and the naming is what that channel is being used for.
The collision occurs in the FW and the FW handles it before sending out a message.
When reading a CAN, there are no collisions, so there are no priorities. So I have no clue what you want here.

9:39 am

Zoltan Miskolci

done

done

9:39 am

Zoltan Miskolci

I have no idea what you are referring to as the link is not working. The need to define the type and the name of the data being read is necessary, so if it's not here it will be somewhere else, tha...

I have no idea what you are referring to as the link is not working.
The need to define the type and the name of the data being read is necessary, so if it's not here it will be somewhere else, that we can't escape.
Exporting that to different files won't serve a purpose and will only increase complexity as when debugging you will need to reference a separate file.
For the defs it made sense as they are used multiple places, but what a message contains is a single use place, so storing it separately is meaningless as it won't have any use outside of this single function.