Activity leahi-dialin/docs/source

11:08 am

Raghu Kallala and Michael Garthwaite

More
LEAHI-DIALIN-LDT-611-1
finished reviewing

10:14 am

Zoltan Miskolci

I added the unique decorator back, except for the few that have aliases

9:32 am

Zoltan Miskolci

Renamed, also flagged for future type change.

9:31 am

Zoltan Miskolci

More
40186f1
changed 10 files
LDT-2004-dialysate-composition-dd, LDT-2004-dry-bicart---dd and 16 more LEAHI-DIALIN-LDT-611-1

- Renamed variable

- -1
- +0
./images
- History
- Source
- Diff
./images
… 9 more files in changeset.

11:52 am

Michael Garthwaite

"No one should interact with it or be aware of it's existence, so the name shouldn't matter." *it matters to those who read the code in inconsistent intervals ( like those who participate in code...

"No one should interact with it or be aware of it's existence, so the name shouldn't matter."

it matters to those who read the code in inconsistent intervals ( like those who participate in code review or teaching ).

"As we only have 2 version in test at the same time."

Currently. By summer, i'd expect dialin to be considering 1.0's, 1.9s, and 2.0s/DVTs.

We have the choice to handle the redesign effort then or now.

Edit:
Follow up comment.

Looking at the other files. Users of dialin will not be aware of existence, but developers of dialin will as it impacts the behavior of overrides like temp & pressure.

11:48 am

Michael Garthwaite

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique ke...

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique keyword to fail. These will not trigger an exception ).

10:46 am

Zoltan Miskolci

I am not sure I can assign unique to the dynamic enums. Also with unique you can't add aliases and some(for example: temperature) overrides use the aliases to determine which msg id to call and how...

I am not sure I can assign unique to the dynamic enums. Also with unique you can't add aliases and some(for example: temperature) overrides use the aliases to determine which msg id to call and how much to shift value for it.
Making an alias is more dynamic and not needing separate variables to be maintained for this.

10:42 am

Zoltan Miskolci

Enum content of Beta 1.0 and Beta 1.9 is different. The new sensors messing up the order for the old HW's override and broadcast data allocation. Making it dynamic makes it that when the beta test ...

Enum content of Beta 1.0 and Beta 1.9 is different. The new sensors messing up the order for the old HW's override and broadcast data allocation.
Making it dynamic makes it that when the beta test config is called the enums are switching content to reflect that.

10:40 am

Zoltan Miskolci

Reasons: *No one should interact with it or be aware of it's existence, so the name shouldn't matter. *As we only have 2 version in test at the same time, I am making an internal variable name th...

Reasons:

No one should interact with it or be aware of it's existence, so the name shouldn't matter.
As we only have 2 version in test at the same time, I am making an internal variable name that I don't need to rename every 3 months or so.
Needing to make a review smaller with editing less thing makes it faster to be completed...

In case a situation arrives when we will test more version at the same time Alpha, Beta, Beta 1.9, it will require a redesign on the part of enum generation too.

10:39 am

Michael Garthwaite

More
Re: LEAHI-DIALIN-LDT-611-1
commented on review

previously we had the unique keyword above our classes as a developer sanity check to ensure the dev didnt duplicate values in the dict since we dont auto generate this defs. if i remember correct...

previously we had the unique keyword above our classes as a developer sanity check to ensure the dev didnt duplicate values in the dict since we dont auto generate this defs.

if i remember correctly, unique is checked when the enum class is imported. We test it our unit tests, both test_constructors and test_imports.

The reason we currently would want to keep unique is because the DialinEnum class has the method has_value(). Without knowing the current usage of this function from our users, it will impact users expected behavior.

My question to you: Should we continue to test and check how the defs for duplicates?

10:19 am