leahi-dialin / leahi_dialin / dd / modules

spent_chamber_fill.py

Clone Tools

Stats

Commits this week: 0
Total Committers: 1
Last Commit: 11 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Sep
2:42 pm

jpaguio  (deleted user)

2:35 pm

Dara Navaei and Sean Nash

12:57 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2300: Resolved code review comments

Options
    • -2
    • +2
    ./spent_chamber_fill.py
  2. … 40 more files in changeset.
12:16 pm

jpaguio  (deleted user)

Done - timestamps added to DD, FP, and TD

Done - timestamps added to DD, FP, and TD

12:13 pm

jpaguio  (deleted user)

Done

Done

12:12 pm

jpaguio  (deleted user)

Done

Done

12:11 pm

jpaguio  (deleted user)

Done

Done

Monday 22 Sep
2:26 pm

jpaguio  (deleted user)

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only...

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only one "variable" is being published. The same goes for the other publish functions before each handler. I will reorganize the order of the published variables so that timestamp is listed last.

9:48 am

Sean Nash

No timestamp?

No timestamp?

9:45 am

Sean Nash

I didn't see dbg variables in the publish list above.

I didn't see dbg variables in the publish list above.

9:44 am

Sean Nash

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere. Also, I think we typically list the timestamp ...

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere.
Also, I think we typically list the timestamp last.

9:41 am

Sean Nash

Replace "dg" with "dd".

Replace "dg" with "dd".

9:38 am

Sean Nash

Replace "hd" with "dd".

Replace "hd" with "dd".

Monday 15 Sep
4:49 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2300: Added message ID to each observer

Options
    • -3
    • +4
    ./spent_chamber_fill.py
  2. … 40 more files in changeset.
4:03 pm

Dara Navaei

LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
Wednesday 27 Aug
2:35 pm

jpaguio  (deleted user)

1:44 pm

Sean Nash , Vinayakam Mani and Michael Garthwaite

11:04 am

jpaguio  (deleted user)

Done

Done

10:52 am

Jonny Paguio <jpaguio@diality.com>

LDT-1873: Updated handler and override names

Options
    • -3
    • +3
    ./spent_chamber_fill.py
10:36 am

Vinayakam Mani

Please raname handler_spent_chamber_fill_sync() . Also do the same for the below broadcast interval function as well ( cmd_spent_chamber_fill_broadcast_interval_overirde)

Please raname handler_spent_chamber_fill_sync() . Also do the same for the below broadcast interval function as well ( cmd_spent_chamber_fill_broadcast_interval_overirde)

Tuesday 26 Aug
4:19 pm

Dara Navaei

4:19 pm

Jonny Paguio <jpaguio@diality.com>

LDT-1873: Renamed file and updated comments to Spent Chamber Fill

Options
    • -0
    • +107
    ./spent_chamber_fill.py
  2. … 1 more file in changeset.
4:06 pm

jpaguio  (deleted user)

4:06 pm

jpaguio  (deleted user)

3:59 pm

Dara Navaei

LEAHI-DIALIN-LDT-1873_Dialysate Flow Rate DD
LEAHI-DIALIN-LDT-1873_Dialysate Flow Rate DD