leahi-dialin / leahi_dialin / fp / modules

conductivity_sensors.py

Clone Tools

Stats

Commits this week: 2
Total Committers: 4
Last Commit: 11 Dec
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 11 Dec
12:04 pm

Dara Navaei

Wednesday 10 Dec
9:03 am

Zoltan Miskolci

when I get the version with python3 version.py it will show the correct branch and commit version instead of just 1.0.0, which tells nothing. I use this when they ask what version of dialin I have,...

when I get the version with python3 version.py it will show the correct branch and commit version instead of just 1.0.0, which tells nothing.
I use this when they ask what version of dialin I have, as I know the branch, but not the commit version, and it's faster with this then asking git around.

8:56 am

Dara Navaei

Why was this changed?

Why was this changed?

Tuesday 09 Dec
2:11 pm

Sean Nash

2:07 pm

Zoltan Miskolci

added handler initialization to __init__

Options
    • -2
    • +4
    ./conductivity_sensors.py
Monday 08 Dec
4:38 pm

Zoltan Miskolci

Added missing broadcast message

Options
    • -0
    • +25
    ./conductivity_sensors.py
Thursday 04 Dec
10:14 am

Zoltan Miskolci

LDT-598: - Copied and merged all constants file into one in common (For future ease of removal) - Created a generic broadcast override template - Created enum for RO Rejection Ratio - Created handler for RO Rejection Ratio - Created overrides for RO Rejection Ration - Added MSG_IDs related to RO Rejection Ratio - Added missing Msg_id for dd voltages handler

Options
    • -33
    • +81
    ./conductivity_sensors.py
  2. … 6 more files in changeset.
10:00 am

Dara Navaei

LEAHI-DIALIN-LDT-598_FP: Add FW and Dialin capability to report the RO rejection ratio
LEAHI-DIALIN-LDT-598_FP: Add FW and Dialin capability to report the RO rejection ratio
Wednesday 03 Dec
1:40 pm

Zoltan Miskolci

LDT-598: - Copied and merged all constants file into one in common (For future ease of removal) - Created a generic broadcast override template - Created enum for RO Rejection Ratio - Created handler for RO Rejection Ratio - Created overrides for RO Rejection Ration - Added MSG_IDs related to RO Rejection Ratio - Added missing Msg_id for dd voltages handler

Options
    • -33
    • +107
    ./conductivity_sensors.py
  2. … 6 more files in changeset.
Thursday 25 Sep
2:42 pm

jpaguio  (deleted user)

2:35 pm

Dara Navaei and Sean Nash

12:57 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2300: Resolved code review comments

Options
    • -1
    • +1
    ./conductivity_sensors.py
  2. … 40 more files in changeset.
12:16 pm

jpaguio  (deleted user)

Done - timestamps added to DD, FP, and TD

Done - timestamps added to DD, FP, and TD

12:13 pm

jpaguio  (deleted user)

Done

Done

12:12 pm

jpaguio  (deleted user)

Done

Done

12:11 pm

jpaguio  (deleted user)

Done

Done

Monday 22 Sep
2:26 pm

jpaguio  (deleted user)

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only...

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only one "variable" is being published. The same goes for the other publish functions before each handler. I will reorganize the order of the published variables so that timestamp is listed last.

9:48 am

Sean Nash

No timestamp?

No timestamp?

9:45 am

Sean Nash

I didn't see dbg variables in the publish list above.

I didn't see dbg variables in the publish list above.

9:44 am

Sean Nash

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere. Also, I think we typically list the timestamp ...

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere.
Also, I think we typically list the timestamp last.

9:41 am

Sean Nash

Replace "dg" with "dd".

Replace "dg" with "dd".

9:38 am

Sean Nash

Replace "hd" with "dd".

Replace "hd" with "dd".

Monday 15 Sep
4:49 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2300: Added message ID to each observer

Options
    • -3
    • +3
    ./conductivity_sensors.py
  2. … 40 more files in changeset.
4:03 pm

Dara Navaei

LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
Thursday 21 Aug
4:36 pm

jpaguio  (deleted user)

2:30 pm

Michael Garthwaite and Vinayakam Mani

2:04 pm

Dara Navaei

LEAHI-DIALIN-LDT-2070_Leahi Dialin Move Dictionary EN
LEAHI-DIALIN-LDT-2070_Leahi Dialin Move Dictionary EN
Friday 15 Aug
5:21 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2070: Updated DD, FP, TD sensor and valve modules to use enumerated classes

Options
    • -8
    • +9
    ./conductivity_sensors.py
  2. … 18 more files in changeset.
Wednesday 06 Aug
12:41 pm

jpaguio  (deleted user)

12:26 pm

Dara Navaei