leahi-fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merged LDT-3259

Done

Done

LDT-3259 addressed the code review comments

Done

Done

This file was updated automatically using HALCoGen.

This file was updated automatically using HALCoGen.

Missing other test functions in the substitution pump (publish, target speed.)?

Missing other test functions in the substitution pump (publish, target speed.)?

update original author name and date.

update original author name and date.

update all test functions header and descriptions, Input, outputs and param sections.

update all test functions header and descriptions, Input, outputs and param sections.

Are we missing the publish function for the substitution pump?

Are we missing the publish function for the substitution pump?

are we checking any range here? if not, remove the above comment.

are we checking any range here? if not, remove the above comment.

Substitution pump. replace across the file.

Substitution pump. replace across the file.

Remove blank line

Remove blank line

Ramp to target speed state is missing?

Ramp to target speed state is missing?

Can we change the MACRO name to 64 step, if we are using 64 micro steps for HDF?

Can we change the MACRO name to 64 step, if we are using 64 micro steps for HDF?

Do we need to add the D92 pump speed read registers and handle appropriate monitor functions in Substitution Pump controller file?

Do we need to add the D92 pump speed read registers and handle appropriate monitor functions in Substitution Pump controller file?

Done

Done

Done

Done

add a blank line.

add a blank line.

Change to HDF pump. also update D92 instead of D76.

Change to HDF pump. also update D92 instead of D76.

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

Remove blank line

Remove blank line

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

If you disable mpu in the HALCoGen, this code will not be created.

If you disable mpu in the HALCoGen, this code will not be created.

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

same.

same.

same.

same.

We shouldn't delete Halcogen code. Add a #if 0 in this user code section and add a #endif in the user code section following _coreEnableFlashEcc() call.

We shouldn't delete Halcogen code.
Add a #if 0 in this user code section and add a #endif in the user code section following _coreEnableFlashEcc() call.