leahi-fwcommon

Clone Tools

Stats

Commits this week: 19
Total Committers: 16
Last Commit: 17:05
Commits this week: 19

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 27 Jul
11:23 am

Vendor - TEL - Arpita Srivastava

Merge branch 'staging' of bitbucket.org:diality-cloud/leahi-fwcommon into LDT-3735-non-volatile-memory

Options
11:21 am

Vendor - TEL - Arpita Srivastava

Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

11:17 am

Vendor - TEL - Arpita Srivastava

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

11:16 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

11:16 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:15 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:14 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

11:12 am

Vendor - TEL - Arpita Srivastava

LDT-3735: Minor

Options
    • -1
    • +0
    /NVJobQ.c
10:14 am

Sean Nash

What is happening here? Not clear if we need cartridge param. Let's remove it for now.

What is happening here? Not clear if we need cartridge param. Let's remove it for now.

10:07 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:07 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:06 am

Sean Nash

Comment these out again.

Comment these out again.

10:06 am

Sean Nash

Move this to right before syringe pump controller below. Add comment "Execute pinch valve command state machine."

Move this to right before syringe pump controller below. Add comment "Execute pinch valve command state machine."

10:05 am

Sean Nash

Move this to right after valves controller exec below.

Move this to right after valves controller exec below.

10:04 am

Sean Nash

Restore this.

Restore this.

10:03 am

Sean Nash

Restore this.

Restore this.

9:56 am

Sean Nash

uncomment this line.

uncomment this line.

9:55 am

Sean Nash

Remove test code.

Remove test code.

9:54 am

Sean Nash

I think we should have handle functions that return next state for each of these cases (just like mode state machines).

I think we should have handle functions that return next state for each of these cases (just like mode state machines).

9:53 am

Sean Nash

I think we should have handle functions that return next state for each of these cases (just like mode state machines).

I think we should have handle functions that return next state for each of these cases (just like mode state machines).

9:51 am

Sean Nash

Remove extra blank lines and comment.

Remove extra blank lines and comment.

9:50 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

9:50 am

Sean Nash

Remove this comment?

Remove this comment?

9:49 am

Sean Nash

Just have a comment here that says "Ok - do nothing."

Just have a comment here that says "Ok - do nothing."

9:49 am

Sean Nash

If we don't need this code, remove it.

If we don't need this code, remove it.

9:48 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:48 am

Sean Nash

Add a TODO comment to restore this when Noe fixes FPGA

Add a TODO comment to restore this when Noe fixes FPGA

9:47 am

Sean Nash

Remove blank line.

Remove blank line.

9:46 am

Sean Nash

Why commented out?

Why commented out?

9:44 am

Sean Nash

Missing /// comment.

Missing /// comment.