Activity leahi-fwcommon/

Tree
Accordion

Stats

Commits this week: 14

Total Committers:	16
Last Commit:	19:04
Commits this week:	14

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 04 Aug

10:23 am

Michael Garthwaite

More
e20ec6a
changed 2 files
develop

Merge branch 'LDT-3975-water-treatment-and-degassing--' into develop

- -4
- +0
/PIControllers.h
- History
- Source
- Diff
/PIControllers.h
- -2
- +7
/PIDControllers.h
- History
- Source
- Diff
/PIDControllers.h

10:13 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

When we send any message to UI, usually add the message id in the doxygen header like this. @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the function s...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

9:55 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

It looks like the rows may be misaligned with the alarm ID declarations. For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

It looks like the rows may be misaligned with the alarm ID declarations.
For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

9:53 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

Should Instructions part be this? A problem was detected with the hemodialysis device.

Should Instructions part be this?

A problem was detected with the hemodialysis device.

9:50 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

Please confirm if the source is DD?

Please confirm if the source is DD?

9:32 am

Michael Garthwaite

More
860e970
changed 0 files
LDT-3975-water-treatment-and-degassing--, develop

Merge branch 'staging' into LDT-3975-water-treatment-and-degassing--

Monday 03 Aug

4:06 pm

suresh

More
6ec1c6d
changed 1 file
LDT-4063-power-control-and-post---fw-imp, LDT-4063-power-control-and-post---fw-imp-fix, staging LEAHI-TD-FIRMWARE-LDT-4063-1

LDT-4063: fixed merge conflicts

- -2
- +2
/WatchdogMgmt.c
- History
- Source
- Diff
/WatchdogMgmt.c

3:03 pm

suresh

More
3359995
changed 1 file
LDT-4063-power-control-and-post---fw-imp, LDT-4063-power-control-and-post---fw-imp-fix, staging LEAHI-TD-FIRMWARE-LDT-4063-1

LDT-4063: Addressed review comments

- -1
- +2
/WatchdogMgmt.c
- History
- Source
- Diff
/WatchdogMgmt.c

11:05 am

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-4873-2
started review

LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault

LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault

Friday 31 Jul

9:33 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

What is the use case of including this header?

What is the use case of including this header?

9:33 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

What is the use case of including this header?

What is the use case of including this header?

9:32 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

Should we move this up before the test functions?

Should we move this up before the test functions?

9:32 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

Add @messages MSG_ID_TD_POST_FINAL_TEST_RESULT

Add @messages MSG_ID_TD_POST_FINAL_TEST_RESULT

9:32 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

Add @messages MSG_ID_TD_POST_SINGLE_TEST_RESULT

Add @messages MSG_ID_TD_POST_SINGLE_TEST_RESULT

9:31 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

is the function description correct? change DG -> DD

is the function description correct?
change DG -> DD

9:31 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

output is none

output is none

9:30 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

add safetyShutdownSelfTestStatus to outputs

add safetyShutdownSelfTestStatus to outputs

9:28 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

why is this line commented out? Should we remove it or add a TODO?

why is this line commented out? Should we remove it or add a TODO?

9:27 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

Remove blank line

Remove blank line

9:26 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

align comment

align comment

9:26 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

break this line

break this line

9:25 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

9:25 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

9:24 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

remove blank line

remove blank line

Thursday 30 Jul

5:52 pm

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-4049-1
resumed reviewing

4:58 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

Add @alarms

Add @alarms

3:44 pm

Vendor - TEL - Jashwant Gantyada

More
689348f
changed 0 files
LDT-4009-isolated-uf-td

Merge branch 'staging' into LDT-4009-isolated-uf-td

3:32 pm

Vendor - TEL - Jashwant Gantyada

More
eae65ea
changed 0 files
LDT-4009-isolated-uf-td

Merge branch 'staging' into LDT-4009-isolated-uf-td

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-08-07 21:42 -0700