leahi-fwcommon

Comm.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 5
Last Commit: 29 Jul 24
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Dec
9:26 pm

Sean Nash

Why two output lines?

Why two output lines?

9:25 pm

Sean Nash

All cases seem a little off on indents, especially this one.

All cases seem a little off on indents, especially this one.

9:24 pm

Sean Nash

For default cases (throughout this unit), we either need a s/w fault (because this should never happen and indicates memory corruption) or a comment noting it is ok to ignore invalid cases (command...

For default cases (throughout this unit), we either need a s/w fault (because this should never happen and indicates memory corruption) or a comment noting it is ok to ignore invalid cases (commands in this case).

Friday 21 Nov
10:07 am

Sean Nash

Should we be calling get function in monitor instead of driver here?

Should we be calling get function in monitor instead of driver here?

10:06 am

Sean Nash

No overrides?

No overrides?

10:05 am

Sean Nash

Fix indent.

Fix indent.

10:05 am

Sean Nash

Use a #define instead of 1000.

Use a #define instead of 1000.

10:02 am

Sean Nash

If no parameters, just don't have any param lines (don't say none).

If no parameters, just don't have any param lines (don't say none).

10:01 am

Sean Nash

No param, so remove this line.

No param, so remove this line.

10:01 am

Sean Nash

measurementSettingsTX is an output.

measurementSettingsTX is an output.

10:00 am

Sean Nash

Seems like eePromDataTX is an output, not an input.

Seems like eePromDataTX is an output, not an input.

10:00 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:59 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:58 am

Sean Nash

Add comment to right.

Add comment to right.

9:57 am

Sean Nash

///

///

9:57 am

Sean Nash

Add space between } and type name.

Add space between } and type name.

9:56 am

Sean Nash

///

///

9:56 am

Sean Nash

Add space between } and type name.

Add space between } and type name.

9:56 am

Sean Nash

///

///

9:56 am

Sean Nash

Add space between } and type name.

Add space between } and type name.

9:55 am

Sean Nash

///

///

9:55 am

Sean Nash

///

///

9:55 am

Sean Nash

Use /// here so doxygen will pick it up.

Use /// here so doxygen will pick it up.

Thursday 13 Nov
12:50 pm

Sean Nash

Put in #ifdef.

Put in #ifdef.

Wednesday 12 Nov
5:17 pm

Vinayakam Mani

error count or reading temperature?

error count or reading temperature?

4:49 pm

Vinayakam Mani

Remove extra line.

Remove extra line.

4:37 pm

Vinayakam Mani

Add the comments for coefficients. bring a top-level comment explaining the formula where these coefficients are being used.

Add the comments for coefficients. bring a top-level comment explaining the formula where these coefficients are being used.

4:35 pm

Vinayakam Mani

Align the comments in fixed indentation throughout the file.

Align the comments in fixed indentation throughout the file.

3:57 pm

Vinayakam Mani

space b/w '}' and 'Conductivity'. seen other places too in the file, please check and update.

space b/w '}' and 'Conductivity'. seen other places too in the file, please check and update.

3:53 pm

Vinayakam Mani

UNINITIALIZED?

UNINITIALIZED?