ro-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 2
Total Committers: 5
Last Commit: 18 Dec
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 03 Nov
9:10 am

Michael Garthwaite

LDT-2116: code review updates. Change target flow rate from 700 to 750 per system spec. Reverted debugging broadcast for RO Pump.

Options
    • -1
    • +1
    ./PermeateTank.c
    • -10
    • +10
    ./ROPump.c
  3. … 3 more files in changeset.
Friday 31 Oct
8:49 am

Raghu Kallala

LDT-2116 added private def for RO pump target flow

Options
    • -1
    • +2
    ./PermeateTank.c
Tuesday 21 Oct
9:46 am

Michael Garthwaite

LDT-2116: possible fix for open loop to target flow transition.

Options
    • -1
    • +2
    ./ROPump.c
Monday 20 Oct
8:35 pm

Michael Garthwaite

LDT-2116: updates to ro pump coefficients. updates to permeate tank control while P39 is closed.

Options
    • -2
    • +5
    ./PermeateTank.c
    • -15
    • +13
    ./ROPump.c
  3. … 1 more file in changeset.
Monday 29 Sep
2:14 pm

Michael Garthwaite

LDT-1773: updated comments for fpga interface. changed valve pwm period to correct value

Options
    • -5
    • +5
    ./Valves.c
  2. … 2 more files in changeset.
Friday 19 Sep
8:58 am

Michael Garthwaite

LDT-1773: implemented FPGA interface for valve PWM. implemented in valves module

Options
    • -0
    • +12
    ./Valves.c
  2. … 2 more files in changeset.
Thursday 04 Sep
1:19 pm

Raghu Kallala

LDT-1809 Resolved conflicts while merging staging

Options
    • -16
    • +35
    ./ROPump.c
  2. … 3 more files in changeset.
Wednesday 03 Sep
9:44 am

Michael Garthwaite

LDT-1242: code review comments. comment aligning. fix ro pump control calling set pwm pct when it should have been pwm cnt

Options
    • -8
    • +11
    ./PermeateTank.c
    • -11
    • +11
    ./ROPump.c
  3. … 3 more files in changeset.
8:49 am

Michael Garthwaite

LDT-1242: reverted RO controller publishing to no longer contain controller debug data

Options
    • -5
    • +5
    ./ROPump.c
Friday 29 Aug
9:12 am

Michael Garthwaite

LDT-1242: updated tank full timing

Options
    • -2
    • +2
    ./PermeateTank.c
8:56 am

Michael Garthwaite

LDT-1242: reverted flow control output for develop builds as pwm output requires tuning

Options
    • -7
    • +9
    ./ROPump.c
Thursday 28 Aug
9:39 am

Michael Garthwaite

LDT-1242: opening P34 on tank full state.

Options
    • -2
    • +2
    ./PermeateTank.c
9:30 am

Michael Garthwaite

LDT-1242: converted RO flow control back to outputting PWM percentages instead of target mL/min.

Options
    • -13
    • +12
    ./ROPump.c
8:51 am

Michael Garthwaite

LDT-1242: updated flow control curve. Renamed fp def op modes. Closing P39 on TANK FULL state

Options
    • -1
    • +1
    ./PermeateTank.c
    • -2
    • +2
    ./ROPump.c
  3. … 4 more files in changeset.
Wednesday 27 Aug
2:54 pm

Raghu Kallala

Fixed indentation and review comments

Options
    • -18
    • +18
    ./ROPump.c
Tuesday 26 Aug
2:54 pm

Raghu Kallala

fixed review comments

Options
    • -30
    • +53
    ./ROPump.c
  2. … 2 more files in changeset.
10:37 am

Raghu Kallala

Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

Options
    • -100
    • +62
    ./ROPump.c
    • -3
    • +3
    ./ROPump.h
  3. … 4 more files in changeset.
Monday 25 Aug
12:40 pm

Michael Garthwaite

LDT-566: updated RO pwm flow curve from linear to logarithmic.

Options
    • -6
    • +7
    ./ROPump.c
12:40 pm

Michael Garthwaite

LDT-566: updated RO pwm flow curve from linear to logarithmic.

Options
    • -6
    • +7
    ./ROPump.c
Wednesday 20 Aug
8:59 am

Raghu Kallala

removed commented code per review comments

Options
    • -1
    • +0
    ./ROPump.c
Tuesday 19 Aug
10:14 am

Raghu Kallala

declared result at the top of the scope for test functions

Options
    • -3
    • +6
    ./ROPump.c
9:42 am

Michael Garthwaite

LDT-1242: updated permeate tank control to change based on low level.

Options
    • -6
    • +10
    ./PermeateTank.c
  2. … 1 more file in changeset.
Thursday 14 Aug
1:08 pm

Michael Garthwaite

LDT-566: reverted publishing change for fine tuning.

Options
    • -5
    • +5
    ./ROPump.c
1:07 pm

Michael Garthwaite

LDT-566: fixed RO Pump publishing to no longer have debug data for PI control

Options
    • -5
    • +5
    ./ROPump.c
11:11 am

Michael Garthwaite

LDT-2003: 1st stage of flow control. still wip. moved event from bad crc error to all faults.

Options
    • -18
    • +35
    ./ROPump.c
  2. … 2 more files in changeset.
Wednesday 13 Aug
3:00 pm

Raghu Kallala

Removed commented code lines

Options
    • -2
    • +0
    ./ROPump.c
1:46 pm

Raghu Kallala

Addressed review comments and modified the override behavior as discussed.

Options
    • -174
    • +161
    ./ROPump.c
    • -1
    • +1
    ./ROPump.h
  3. … 1 more file in changeset.
12:34 pm

Michael Garthwaite

LDT-566: moved valve enum from ro firmware repo to common repo

Options
    • -20
    • +20
    ./Valves.c
    • -21
    • +5
    ./Valves.h
  3. … 1 more file in changeset.
12:34 pm

Michael Garthwaite

LDT-566: moved valve enum from ro firmware repo to common repo

Options
    • -20
    • +20
    ./Valves.c
    • -21
    • +5
    ./Valves.h
  3. … 1 more file in changeset.
Monday 11 Aug
10:15 am

Raghu Kallala

Addressed review comments to remove blank lines

Options
    • -6
    • +0
    ./ROPump.c