ro-firmware / firmware / App / Modes

InletPressureCheck.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 1
Last Commit: 24 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 03 Sep
8:52 am

Michael Garthwaite

Tuesday 02 Sep
11:08 am

Raghu Kallala

10:03 am

Dara Navaei

LEAHI-RO-FIRMWARE-LDT-1242_IOFP - Finalize Permeate Tank Level Control
LEAHI-RO-FIRMWARE-LDT-1242_IOFP - Finalize Permeate Tank Level Control
Thursday 28 Aug
2:17 pm

Michael Garthwaite and Sean Nash

1:40 pm

Raghu Kallala

Calling it regardless of hardware

Calling it regardless of hardware

Wednesday 27 Aug
1:54 pm

Sean Nash

Follow up with Eliza on TODO question.

Follow up with Eliza on TODO question.

8:14 am

Raghu Kallala

Pushed the commit

Pushed the commit

8:12 am

Raghu Kallala

Done

Done

8:12 am

Raghu Kallala

Done

Done

Tuesday 26 Aug
1:38 pm

Sean Nash

Looks like it's still here.

Looks like it's still here.

Monday 25 Aug
3:07 pm

Michael Garthwaite

Current builds of the FP are not triggering alarms. Alarms and recovery states ( ex: paused states ) will be implemented and covered in https://diality.atlassian.net/browse/LDT-828 once requirement...

Current builds of the FP are not triggering alarms. Alarms and recovery states ( ex: paused states ) will be implemented and covered in https://diality.atlassian.net/browse/LDT-828 once requirement draft is finalized.

Thursday 21 Aug
9:20 am

Sean Nash

If in paused state due to alarm, if alarm is recoverable we would need a way to go back to in progress state when user clears alarm.

If in paused state due to alarm, if alarm is recoverable we would need a way to go back to in progress state when user clears alarm.

Wednesday 20 Aug
10:00 am

Raghu Kallala

Done.

Done.

10:00 am

Raghu Kallala

Yeah, I agree. We can remove it

Yeah, I agree.
We can remove it

9:57 am

Raghu Kallala

Yes, will be in paused state, until we do the PreGen mode again.

Yes, will be in paused state, until we do the PreGen mode again.

6:31 am

Raghu Kallala

Addressed review comments.

Options
    • -4
    • +5
    ./InletPressureCheck.h
  2. … 3 more files in changeset.
Tuesday 19 Aug
2:05 pm

Sean Nash

If check completed, are we stuck in this state forever?

If check completed, are we stuck in this state forever?

2:03 pm

Sean Nash

Is this assignment needed? Seems like it would already have to be FALSE to get into the if.

Is this assignment needed? Seems like it would already have to be FALSE to get into the if.

1:33 pm

Sean Nash

Align comments.

Align comments.

1:33 pm

Sean Nash

Add a blank line before group end marker.

Add a blank line before group end marker.

1:32 pm

Sean Nash

Align comments or remove them (not necessary for function prototypes).

Align comments or remove them (not necessary for function prototypes).

10:24 am

Raghu Kallala

Addressed review comments to remove unwanted code lines and handled state assignment.

Options
    • -1
    • +0
    ./InletPressureCheck.h
  2. … 2 more files in changeset.
10:23 am

Raghu Kallala

Removed.

Removed.

10:23 am

Raghu Kallala

Removed.

Removed.

10:23 am

Raghu Kallala

Removed.

Removed.

10:23 am

Raghu Kallala

Updated, thanks.

Updated, thanks.

Monday 18 Aug
9:06 am

Michael Garthwaite

Dont think we will need to control the permeate tank in this state

Dont think we will need to control the permeate tank in this state

9:04 am

Michael Garthwaite

Please remove unnecessary #include's like ROPump, PermeateTank, Conductivity, etc.

Please remove unnecessary #include's like ROPump, PermeateTank, Conductivity, etc.

9:02 am

Michael Garthwaite

Remove commented function header.

Remove commented function header.

9:01 am

Michael Garthwaite

Similar to how we have the if statement above, please assign the state to FP_PRE_GENP_FILTER_FLUSH once we complete the pressure check.

Similar to how we have the if statement above, please assign the state to FP_PRE_GENP_FILTER_FLUSH once we complete the pressure check.