ro-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 6
Last Commit: 24 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 26 Aug
10:37 am

Raghu Kallala

Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

Options
    • -1
    • +1
    ./FlushConcentrate.c
    • -1
    • +1
    ./FlushPermeate.c
    • -1
    • +1
    ./ModeGenPermeate.c
    • -1
    • +1
    ./ModePreGenPermeate.c
  5. … 2 more files in changeset.
Wednesday 20 Aug
6:31 am

Raghu Kallala

Addressed review comments.

Options
    • -7
    • +7
    ./InletPressureCheck.c
    • -4
    • +5
    ./InletPressureCheck.h
    • -0
    • +1
    ./ModePreGenPermeate.c
  4. … 1 more file in changeset.
Tuesday 19 Aug
10:24 am

Raghu Kallala

Addressed review comments to remove unwanted code lines and handled state assignment.

Options
    • -4
    • +1
    ./InletPressureCheck.c
    • -1
    • +0
    ./InletPressureCheck.h
    • -0
    • +1
    ./ModePreGenPermeate.c
Wednesday 13 Aug
3:41 pm

Michael Garthwaite

LDT-566: increased permeate flush timer to 5 minutes to support conductivity testing.

Options
    • -1
    • +1
    ./FlushPermeate.c
12:34 pm

Michael Garthwaite

LDT-566: moved valve enum from ro firmware repo to common repo

Options
    • -2
    • +2
    ./FPModeFault.c
  2. … 2 more files in changeset.
12:34 pm

Michael Garthwaite

LDT-566: moved valve enum from ro firmware repo to common repo

Options
    • -2
    • +2
    ./FPModeFault.c
  2. … 2 more files in changeset.
7:58 am

Raghu Kallala

Implemented Inlet Pressure check functionality with Boost Pump

Options
    • -0
    • +371
    ./InletPressureCheck.c
    • -0
    • +53
    ./InletPressureCheck.h
    • -1
    • +6
    ./ModePreGenPermeate.c
  4. … 3 more files in changeset.
Friday 01 Aug
3:56 pm

Michael Garthwaite

LDT-566: code review comments

Options
    • -1
    • +0
    ./FPModeStandby.c
    • -2
    • +0
    ./FlushConcentrate.c
    • -1
    • +0
    ./ModePreGenPermeate.c
    • -1
    • +0
    ./ModePreGenPermeateDefeatured.h
  5. … 10 more files in changeset.
12:22 pm

Michael Garthwaite

LDT-566: code review comments.

Options
    • -2
    • +4
    ./ModeGenPermeateDefeatured.c
    • -7
    • +6
    ./ModeGenPermeateDefeatured.h
    • -4
    • +8
    ./ModePreGenPermeateDefeatured.c
    • -6
    • +6
    ./ModePreGenPermeateDefeatured.h
  5. … 2 more files in changeset.
12:08 pm

Michael Garthwaite

LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check for boost pump.

Options
    • -0
    • +1
    ./FlushConcentrate.c
    • -0
    • +0
    ./PressureCheck.c
    • -15
    • +0
    ./PressureCheck.h
  4. … 5 more files in changeset.
Thursday 31 Jul
11:49 am

Michael Garthwaite

LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes

Options
    • -1
    • +1
    ./FlushPermeate.c
  2. … 5 more files in changeset.
Wednesday 30 Jul
1:30 pm

Michael Garthwaite

LDT-566: code review comments.

Options
    • -1
    • +1
    ./FPModeStandby.c
    • -19
    • +24
    ./FlushConcentrate.c
    • -2
    • +1
    ./FlushConcentrate.h
    • -10
    • +11
    ./FlushFilter.c
    • -9
    • +13
    ./FlushPermeate.c
    • -30
    • +13
    ./ModeGenPermeate.c
    • -9
    • +4
    ./ModeGenPermeate.h
  8. … 13 more files in changeset.
11:24 am

Michael Garthwaite

LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and clear alarm overrides. Reworked temperature monitor to only publish.

Options
    • -9
    • +7
    ./FPModeFault.c
    • -5
    • +6
    ./FlushConcentrate.c
    • -6
    • +5
    ./FlushFilter.c
    • -7
    • +8
    ./FlushPermeate.c
    • -123
    • +11
    ./ModeGenPermeate.c
    • -4
    • +4
    ./ModeGenPermeateDefeatured.c
    • -24
    • +25
    ./ModePreGenPermeate.c
    • -12
    • +12
    ./ModePreGenPermeateDefeatured.c
  9. … 13 more files in changeset.
Tuesday 29 Jul
1:05 pm

Michael Garthwaite

LDT-566: Implemented FP fault mode. Removed math includes from flush modes.

Options
    • -19
    • +245
    ./FPModeFault.c
    • -1
    • +1
    ./FPModeFault.h
    • -3
    • +0
    ./FlushConcentrate.c
    • -2
    • +0
    ./FlushFilter.c
    • -3
    • +0
    ./FlushPermeate.c
    • -5
    • +5
    ./ModeGenPermeate.c
  7. … 2 more files in changeset.
12:15 pm

Michael Garthwaite

LDT-566: FP Safety shutdown override. fixed includes.

Options
    • -0
    • +1
    ./FPModeFault.c
    • -3
    • +6
    ./FPModeFault.h
    • -2
    • +2
    ./FPModeInitPOST.h
    • -2
    • +2
    ./FPModeStandby.h
    • -2
    • +2
    ./FPOperationModes.h
  6. … 8 more files in changeset.
10:06 am

Michael Garthwaite

WIP on develop

LDT-566: develop fixes

Options
    • -1
    • +1
    ./FlushConcentrate.c
    • -1
    • +1
    ./FlushFilter.c
    • -1
    • +1
    ./FlushPermeate.c
    • -1
    • +1
    ./ModeGenPermeateDefeatured.c
    • -5
    • +5
    ./ModePreGenPermeate.c
    • -3
    • +3
    ./ModePreGenPermeateDefeatured.c
9:58 am

Michael Garthwaite

WIP on develop

LDT-566: code review comments. updated common naming to have a FP prefix.

Options
    • -0
    • +88
    ./FPModeFault.c
    • -0
    • +40
    ./FPModeFault.h
    • -0
    • +66
    ./FPModeInitPOST.c
    • -0
    • +44
    ./FPModeInitPOST.h
    • -0
    • +149
    ./FPModeStandby.c
    • -0
    • +47
    ./FPModeStandby.h
    • -0
    • +475
    ./FPOperationModes.c
    • -0
    • +62
    ./FPOperationModes.h
    • -1
    • +2
    ./FlushConcentrate.c
    • -1
    • +1
    ./FlushFilter.c
    • -2
    • +3
    ./FlushPermeate.c
    • -51
    • +0
    ./ModeFault.c
    • -24
    • +0
    ./ModeFault.h
    • -2
    • +2
    ./ModeGenPermeate.c
    • -2
    • +2
    ./ModeGenPermeateDefeatured.c
  16. … 25 more files in changeset.
Friday 25 Jul
8:28 am

Michael Garthwaite

LDT-566: partial rework of alarm monitoring for water quality based on code review. updated valves to be in sync with latest HDD

Options
    • -0
    • +6
    ./FlushConcentrate.c
    • -0
    • +6
    ./FlushFilter.c
    • -0
    • +6
    ./FlushPermeate.c
    • -1
    • +1
    ./ModeFault.c
    • -0
    • +7
    ./ModeGenPermeate.c
    • -0
    • +6
    ./ModeGenPermeateDefeatured.c
    • -0
    • +3
    ./ModePreGenPermeate.c
    • -0
    • +9
    ./ModePreGenPermeateDefeatured.c
    • -0
    • +3
    ./ModeStandby.c
  10. … 12 more files in changeset.
Tuesday 22 Jul
2:51 pm

Michael Garthwaite

WIP on develop

LDT-566: LDT-676: Removed M7 and P20 valves.

Options
    • -2
    • +0
    ./ModeFault.c
    • -2
    • +0
    ./ModeGenPermeate.c
    • -2
    • +0
    ./ModeStandby.c
  4. … 1 more file in changeset.
Thursday 17 Jul
3:47 pm

Michael Garthwaite

LDT-566: removed unneeded defines. Added percentage values for pwm to RO and boost broadcasts. Removed X5 from pressure sensors. Fixed Pre-Generate mode rushing through sub states.

Options
    • -17
    • +12
    ./ModeGenPermeate.c
  2. … 12 more files in changeset.
Tuesday 15 Jul
4:31 pm

Michael Garthwaite

LDT-566: Implemented hard stop commands for water pumps. Added valve actuation for RO recovery settings in gen permeate, set to med.

Options
    • -0
    • +5
    ./ModeFault.c
    • -4
    • +10
    ./ModeGenPermeate.c
    • -2
    • +2
    ./ModePreGenPermeate.c
  4. … 5 more files in changeset.
3:54 pm

Michael Garthwaite

LDT-566: transitioning to standby mode and fault mode will now shut off pumps and close valves. updates in naming. fixed pre-gen transitioning. removed some checks for when gen water request it received.

Options
    • -2
    • +21
    ./ModeFault.c
    • -12
    • +23
    ./ModeGenPermeate.c
    • -1
    • +2
    ./ModePreGenPermeate.c
    • -2
    • +2
    ./ModePreGenPermeateDefeatured.c
    • -0
    • +21
    ./ModeStandby.c
    • -1
    • +1
    ./OperationModes.c
  7. … 8 more files in changeset.
Wednesday 09 Jul
2:23 pm

Michael Garthwaite

LDT-566: fixed compiiler err

Options
    • -2
    • +2
    ./FlushFilter.c
2:23 pm

Michael Garthwaite

LDT-566: updated flush exec functions to only call the transition function in one location.

Options
    • -5
    • +7
    ./FlushConcentrate.c
    • -6
    • +7
    ./FlushFilter.c
    • -4
    • +6
    ./FlushPermeate.c
2:14 pm

Michael Garthwaite

LDT-566: generate water modes both defeatured and ro featured

Options
    • -0
    • +395
    ./FlushConcentrate.c
    • -7
    • +48
    ./FlushConcentrate.h
    • -0
    • +6
    ./FlushFilter.c
    • -5
    • +17
    ./FlushPermeate.c
    • -21
    • +121
    ./ModeGenPermeate.c
    • -0
    • +4
    ./ModeGenPermeate.h
    • -5
    • +299
    ./ModeGenPermeateDefeatured.c
    • -1
    • +46
    ./ModeGenPermeateDefeatured.h
    • -7
    • +94
    ./ModePreGenPermeate.c
    • -7
    • +359
    ./ModePreGenPermeateDefeatured.c
    • -1
    • +46
    ./ModePreGenPermeateDefeatured.h
    • -13
    • +0
    ./ModeStandby.c
    • -0
    • +0
    ./VerifyWater.c
    • -15
    • +0
    ./VerifyWater.h
  15. … 15 more files in changeset.
Wednesday 02 Jul
12:04 pm

Michael Garthwaite

LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush implemented.

Options
    • -139
    • +0
    ./FilterFlush.c
    • -51
    • +0
    ./FilterFlush.h
    • -0
    • +0
    ./FlushConcentrate.c
    • -0
    • +15
    ./FlushConcentrate.h
    • -0
    • +365
    ./FlushFilter.c
    • -0
    • +56
    ./FlushFilter.h
    • -0
    • +418
    ./FlushPermeate.c
    • -0
    • +56
    ./FlushPermeate.h
    • -0
    • +0
    ./MembraneFlush.c
    • -15
    • +0
    ./MembraneFlush.h
    • -3
    • +3
    ./ModeFault.h
    • -0
    • +332
    ./ModeGenPermeate.c
    • -0
    • +56
    ./ModeGenPermeate.h
    • -0
    • +28
    ./ModeGenPermeateDefeatured.c
    • -0
    • +11
    ./ModeGenPermeateDefeatured.h
  16. … 56 more files in changeset.
Monday 30 Jun
5:32 pm

Michael Garthwaite

LDT-566: code review comments

Options
    • -0
    • +1
    ./ModeWaterPreGen.c
  2. … 7 more files in changeset.
1:59 pm

Michael Garthwaite

LDT-566: code review comments

Options
    • -3
    • +1
    ./FilterFlush.c
    • -0
    • +1
    ./ModeStandby.c
    • -1
    • +0
    ./ModeWaterGen.c
    • -2
    • +2
    ./ModeWaterPreGen.c
    • -11
    • +9
    ./OperationModes.c
    • -1
    • +0
    ./OperationModes.h
  7. … 8 more files in changeset.
Wednesday 25 Jun
9:08 am

Michael Garthwaite

LDT-566: renamed water generation defs

Options
    • -10
    • +10
    ./ModeWaterGen.c
Tuesday 24 Jun
3:23 pm

Michael Garthwaite

LDT-566: Implemented missing overrides for op mode.

Options
    • -0
    • +56
    ./OperationModes.c
    • -0
    • +3
    ./OperationModes.h
  3. … 1 more file in changeset.