ro-firmware / firmware

App

Clone Tools

Stats

Commits this week: 4
Total Committers: 6
Last Commit: 18 Dec
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 13 Aug
3:41 pm

Michael Garthwaite

LDT-566: increased permeate flush timer to 5 minutes to support conductivity testing.

Options
    • -1
    • +1
    ./Modes/FlushPermeate.c
3:00 pm

Raghu Kallala

Removed commented code lines

Options
    • -2
    • +0
    ./Controllers/ROPump.c
1:46 pm

Raghu Kallala

Addressed review comments and modified the override behavior as discussed.

Options
    • -174
    • +161
    ./Controllers/ROPump.c
    • -1
    • +1
    ./Controllers/ROPump.h
    • -1
    • +1
    ./Drivers/FluidPump.h
12:34 pm

Michael Garthwaite

LDT-566: moved valve enum from ro firmware repo to common repo

Options
    • -20
    • +20
    ./Controllers/Valves.c
    • -21
    • +5
    ./Controllers/Valves.h
    • -2
    • +2
    ./Modes/FPModeFault.c
12:34 pm

Michael Garthwaite

LDT-566: moved valve enum from ro firmware repo to common repo

Options
    • -20
    • +20
    ./Controllers/Valves.c
    • -21
    • +5
    ./Controllers/Valves.h
    • -2
    • +2
    ./Modes/FPModeFault.c
12:32 pm

Michael Garthwaite

LDT-566: added an event trigger for bad crc alarm to assist in debugging.

Options
    • -0
    • +2
    ./Services/SystemCommFP.c
7:58 am

Raghu Kallala

Implemented Inlet Pressure check functionality with Boost Pump

Options
    • -0
    • +371
    ./Modes/InletPressureCheck.c
    • -0
    • +53
    ./Modes/InletPressureCheck.h
    • -1
    • +6
    ./Modes/ModePreGenPermeate.c
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
    • -1
    • +3
    ./Services/Messaging.c
  6. … 1 more file in changeset.
Monday 11 Aug
4:50 pm

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./FPCommon.h
3:56 pm

Michael Garthwaite

LDT-566: removed alarm trigger for bad crc's in order to unblock sys testing.

Options
    • -1
    • +2
    ./Services/SystemCommFP.c
10:15 am

Raghu Kallala

Addressed review comments to remove blank lines

Options
    • -6
    • +0
    ./Controllers/ROPump.c
Friday 08 Aug
11:53 am

Raghu Kallala

Fix for RO Pump override set and reset.

Options
    • -75
    • +239
    ./Controllers/ROPump.c
11:34 am

Raghu Kallala

Modified handlers to change state based on data value rather than using get functions.

Options
    • -11
    • +11
    ./Controllers/ROPump.c
Thursday 07 Aug
2:22 pm

Raghu Kallala

Fixed the override reset behavior in test function

Options
    • -3
    • +12
    ./Controllers/ROPump.c
12:10 pm

Michael Garthwaite

Merge branch 'staging' into feature/LDT-1809-iofp-ws-setup-and-bug-fixing

Options
    • -7
    • +4
    ./Controllers/ROPump.c
12:08 pm

Raghu Kallala

Changes for RO pump override reset.

Options
    • -31
    • +10
    ./Controllers/ROPump.c
8:46 am

Raghu Kallala

Updated code for multiple override.

Options
    • -61
    • +153
    ./Controllers/ROPump.c
Wednesday 06 Aug
8:24 am

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./FPCommon.h
Tuesday 05 Aug
12:41 pm

Raghu Kallala

WIP for setting multiple overrides

Options
    • -5
    • +14
    ./Controllers/ROPump.c
10:24 am

Raghu Kallala

removed check for zero flow rate

Options
    • -5
    • +0
    ./Controllers/ROPump.c
10:22 am

Raghu Kallala

Added backup variable for pump data and fixed set function behavior

Options
    • -74
    • +154
    ./Controllers/ROPump.c
Monday 04 Aug
9:26 am

Michael Garthwaite

LDT-566: code review comments.

Options
    • -2
    • +0
    ./Controllers/PermeateTank.c
    • -1
    • +0
    ./Services/DDInterface.c
    • -1
    • +1
    ./Services/Messaging.c
Friday 01 Aug
3:56 pm

Michael Garthwaite

LDT-566: code review comments

Options
    • -8
    • +7
    ./Controllers/PermeateTank.c
    • -3
    • +0
    ./Controllers/ROPump.c
    • -1
    • +0
    ./Modes/FPModeStandby.c
    • -2
    • +0
    ./Modes/FlushConcentrate.c
    • -1
    • +0
    ./Modes/ModePreGenPermeate.c
    • -1
    • +0
    ./Modes/ModePreGenPermeateDefeatured.h
    • -1
    • +0
    ./Monitors/Pressure.c
    • -4
    • +0
    ./Monitors/Temperature.c
    • -1
    • +0
    ./Services/AlarmMgmtFP.h
    • -6
    • +0
    ./Services/DDInterface.c
    • -1
    • +1
    ./Services/DDInterface.h
    • -1
    • +0
    ./Services/FpgaFP.c
    • -4
    • +3
    ./Services/Messaging.c
    • -1
    • +0
    ./Services/SystemCommFP.c
12:22 pm

Michael Garthwaite

LDT-566: code review comments.

Options
    • -1
    • +1
    ./Drivers/ConductivitySensor.c
    • -2
    • +4
    ./Modes/ModeGenPermeateDefeatured.c
    • -7
    • +6
    ./Modes/ModeGenPermeateDefeatured.h
    • -4
    • +8
    ./Modes/ModePreGenPermeateDefeatured.c
    • -6
    • +6
    ./Modes/ModePreGenPermeateDefeatured.h
  6. … 1 more file in changeset.
12:08 pm

Michael Garthwaite

LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check for boost pump.

Options
    • -1
    • +3
    ./Controllers/BoostPump.c
    • -4
    • +6
    ./Controllers/ROPump.c
    • -1
    • +1
    ./Drivers/ConductivitySensor.c
    • -3
    • +3
    ./Drivers/PressureSensor.c
    • -0
    • +1
    ./Modes/FlushConcentrate.c
    • -0
    • +0
    ./Modes/PressureCheck.c
    • -15
    • +0
    ./Modes/PressureCheck.h
    • -5
    • +0
    ./Monitors/WaterQualityMonitor.c
Thursday 31 Jul
11:51 am

Michael Garthwaite

LDT-566: fixed macro calls

Options
    • -4
    • +4
    ./Controllers/ROPump.c
11:49 am

Michael Garthwaite

LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes

Options
    • -3
    • +3
    ./Controllers/BoostPump.c
    • -1
    • +1
    ./Controllers/PermeateTank.c
    • -7
    • +7
    ./Controllers/ROPump.c
    • -1
    • +1
    ./Drivers/FluidPump.h
    • -1
    • +1
    ./Modes/FlushPermeate.c
  6. … 1 more file in changeset.
Wednesday 30 Jul
1:30 pm

Michael Garthwaite

LDT-566: code review comments.

Options
    • -11
    • +5
    ./Controllers/BoostPump.c
    • -650
    • +0
    ./Controllers/Heaters.c
    • -60
    • +0
    ./Controllers/Heaters.h
    • -18
    • +20
    ./Controllers/ROPump.c
    • -3
    • +0
    ./Controllers/ROPump.h
    • -399
    • +0
    ./Drivers/TemperatureSensor.c
    • -59
    • +0
    ./Drivers/TemperatureSensor.h
    • -1
    • +1
    ./Modes/FPModeStandby.c
    • -19
    • +24
    ./Modes/FlushConcentrate.c
    • -2
    • +1
    ./Modes/FlushConcentrate.h
    • -10
    • +11
    ./Modes/FlushFilter.c
    • -9
    • +13
    ./Modes/FlushPermeate.c
    • -30
    • +13
    ./Modes/ModeGenPermeate.c
    • -9
    • +4
    ./Modes/ModeGenPermeate.h
    • -1
    • +0
    ./Monitors/Conductivity.c
  16. … 5 more files in changeset.
11:24 am

Michael Garthwaite

LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and clear alarm overrides. Reworked temperature monitor to only publish.

Options
    • -5
    • +350
    ./Controllers/PermeateTank.c
    • -7
    • +10
    ./Controllers/PermeateTank.h
    • -9
    • +7
    ./Modes/FPModeFault.c
    • -5
    • +6
    ./Modes/FlushConcentrate.c
    • -6
    • +5
    ./Modes/FlushFilter.c
    • -7
    • +8
    ./Modes/FlushPermeate.c
    • -123
    • +11
    ./Modes/ModeGenPermeate.c
    • -4
    • +4
    ./Modes/ModeGenPermeateDefeatured.c
    • -24
    • +25
    ./Modes/ModePreGenPermeate.c
    • -12
    • +12
    ./Modes/ModePreGenPermeateDefeatured.c
    • -1
    • +66
    ./Monitors/Temperature.c
    • -0
    • +20
    ./Monitors/Temperature.h
    • -76
    • +0
    ./Monitors/WaterQualityMonitor.c
    • -19
    • +0
    ./Monitors/WaterQualityMonitor.h
    • -18
    • +26
    ./Services/AlarmMgmtFP.c
  16. … 6 more files in changeset.
Tuesday 29 Jul
3:54 pm

Michael Garthwaite

LDT-566: fixed messaging ACK

Options
    • -4
    • +4
    ./Services/Messaging.c
1:05 pm

Michael Garthwaite

LDT-566: Implemented FP fault mode. Removed math includes from flush modes.

Options
    • -1
    • +1
    ./Controllers/PermeateTank.c
    • -19
    • +245
    ./Modes/FPModeFault.c
    • -1
    • +1
    ./Modes/FPModeFault.h
    • -3
    • +0
    ./Modes/FlushConcentrate.c
    • -2
    • +0
    ./Modes/FlushFilter.c
    • -3
    • +0
    ./Modes/FlushPermeate.c
    • -5
    • +5
    ./Modes/ModeGenPermeate.c
    • -1
    • +1
    ./Services/AlarmMgmtFP.c