ro-firmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 6
Last Commit: 24 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 08 Dec
6:46 pm

Vendor - TEL - Sameer Poyil

comments should start with capital letter

comments should start with capital letter

Monday 01 Dec
12:27 pm

Raghu Kallala

Once Dara enable the copyright script, that will handle it

Once Dara enable the copyright script, that will handle it

9:20 am

Vendor - TEL - Sameer Poyil

Structure packing statement missing. add it even if not required

Structure packing statement missing. add it even if not required

Monday 24 Nov
10:17 am

Vendor - TEL - Sameer Poyil

is this year correct ?

is this year correct ?

10:13 am

Raghu Kallala

Resolved Thanks

Resolved Thanks

10:12 am

Raghu Kallala

Updated copyrights for Messaging source code

Options
    • -1
    • +16
    ./Services/Messaging.c
10:08 am

Raghu Kallala

Will fix on Beta branch to avoid changes to Dialin

Will fix on Beta branch to avoid changes to Dialin

Saturday 22 Nov
12:54 pm

Raghu Kallala

LDT-2116 addressed rewview comments

Options
    • -5
    • +3
    ./Controllers/PermeateTank.c
    • -1
    • +0
    ./Modes/FlushConcentrate.c
    • -2
    • +2
    ./Modes/FlushFilter.c
    • -1
    • +2
    ./Monitors/Conductivity.c
12:52 pm

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

12:52 pm

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

12:42 pm

Raghu Kallala

LDT-2116 addressed review comment

Options
    • -3
    • +3
    ./Modes/ModeGenPermeate.c
    • -1
    • +1
    ./Services/Messaging.c
12:40 pm

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

12:37 pm

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

12:37 pm

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

12:37 pm

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

12:36 pm

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

12:36 pm

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

12:36 pm

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

12:28 pm

Raghu Kallala

LDT-2116 moved ro rejection check to waterQualityMonitors

Options
    • -8
    • +2
    ./Modes/ModeGenPermeate.c
    • -0
    • +21
    ./Monitors/WaterQualityMonitor.c
    • -0
    • +1
    ./Monitors/WaterQualityMonitor.h
Friday 21 Nov
8:47 am

Sean Nash

Remove blank line.

Remove blank line.

Thursday 20 Nov
2:43 pm

Raghu Kallala

Fixed reset during fill and full. Adjusted samples for duty cycle average calculation.

Options
    • -2
    • +10
    ./Controllers/ROPump.c
    • -6
    • +3
    ./Modes/ModeGenPermeate.c
9:30 am

Sean Nash

Remove blank line.

Remove blank line.

9:30 am

Sean Nash

Remove blank line.

Remove blank line.

9:30 am

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

9:30 am

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

9:29 am

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

Tuesday 18 Nov
8:16 pm

Vendor - TEL - Sameer Poyil

let RO comes first , MSG_ID_FP_RO_FILTERED_REJECTION_RATIO

let RO comes first , MSG_ID_FP_RO_FILTERED_REJECTION_RATIO

8:15 pm

Vendor - TEL - Sameer Poyil

use complete word as in line 87 and 88 , PRESSURE

use complete word as in line 87 and 88 , PRESSURE

8:10 pm

Vendor - TEL - Sameer Poyil

copy right file header missing

copy right file header missing

8:05 pm

Vendor - TEL - Sameer Poyil

do not use magic numbers

do not use magic numbers