td-firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT:3970 Addressed Review Comments and Updated Edit Treatment Parameters

    • -0
    • +17
    /firmware/App/Modes/ModeTreatment.c
    • -40
    • +29
    /firmware/App/Services/TxParams.c
    • -30
    • +10
    /firmware/App/Services/TxParams.h
Why do you have {} in the cases?

Why do you have {} in the cases?

You are getting bpResults, but not doing anything with them. Should you pass as parameter to checkBloodPressureReading() function?

You are getting bpResults, but not doing anything with them. Should you pass as parameter to checkBloodPressureReading() function?

Where are these get functions defined? I can't find them.

Where are these get functions defined? I can't find them.

LDT-1886: Resolve merge conflicts

LDT-3259 merged staging

LDT-4033-patient-vitals-fw-implementation

    • -164
    • +81
    /firmware/App/Controllers/BPModule.c
    • -64
    • +81
    /firmware/App/Drivers/BPDriver.c
Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -4
    • +4
    /firmware/App/Controllers/SyringePump.c
    • -4
    • +4
    /firmware/App/Controllers/SyringePump.h
LDT-4072: code comment updates

    • -20
    • +34
    /firmware/App/Drivers/BatteryDriver.c
    • -1
    • +27
    /firmware/App/Drivers/BatteryDriver.h
    • -38
    • +26
    /firmware/App/Monitors/Battery.c
Removed

Removed

Updated

Updated

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

LDT-3215-measured-venous-pressure-decreases

Do we not need the module error alarm?

Do we not need the module error alarm?

This is not an atomic assignment, so we have to consider thread safety. If this driver is running from General Task (I believe it is since ModeTreatment's exec will be calling the BPModule's exec w...

This is not an atomic assignment, so we have to consider thread safety.
If this driver is running from General Task (I believe it is since ModeTreatment's exec will be calling the BPModule's exec which calls this driver's exec) and if the caller to this function will also be running from General Task (I believe it is since BPModule controller is the caller), then there is no thread safety issue and we should mention in the function header brief that this function should only be called from within the General Task.
If another task is involved (e.g. Priority Task is calling this function), this function could be interrupting the get data state while it is populating bpResults with new results and the caller would get a mix of old and new results (we would not want that).

LDT-3215-measured-venous-pressure-decreases

    • -10
    • +39
    /firmware/App/Controllers/AirPump.c
same.

same.

same.

same.

Just like driver state machine, we should only set a request flag to TRUE here and let the state machine handle the transition.

Just like driver state machine, we should only set a request flag to TRUE here and let the state machine handle the transition.

How do we get out of Idle state?

How do we get out of Idle state?

This should be called in all states (so in controller's exec function).

This should be called in all states (so in controller's exec function).

I don't think we want to zero this count here.

I don't think we want to zero this count here.

We need to call the driver exec function from this exec function - either before or after the switch statement.

We need to call the driver exec function from this exec function - either before or after the switch statement.

LDT-1886: Update event related code

We need to call this from ModeTreatment transition function.

We need to call this from ModeTreatment transition function.