td-firmware

Clone Tools

Stats

Commits this week: 29
Total Committers: 18
Last Commit: 24 Jul
Commits this week: 29

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 24 Jul
5:36 pm

Vendor - TEL - Varshini Nagabooshanam

Added doxygen

Options
    • -41
    • +40
    /firmware/App/Controllers/Valves.c
    • -7
    • +7
    /firmware/App/Controllers/Valves.h
    • -1
    • +1
    /firmware/App/Drivers/PinchValve.c
4:46 pm

Sean Nash

4:37 pm

Sean Nash

Can't return in middle of function code.

Can't return in middle of function code.

4:29 pm

Sean Nash

Remove else and reject command in it and re-test.

Remove else and reject command in it and re-test.

4:28 pm

Vendor - TEL - Varshini Nagabooshanam

Added doxygen

Options
    • -9
    • +9
    /firmware/App/Drivers/PinchValve.h
4:25 pm

Vendor - TEL - Varshini Nagabooshanam

Added doxygen

Options
    • -112
    • +112
    /firmware/App/Drivers/PinchValve.c
2:51 pm

Vendor - TEL - Varshini Nagabooshanam

New changes

Options
    • -68
    • +83
    /firmware/App/Drivers/PinchValve.c
    • -16
    • +18
    /firmware/App/Drivers/PinchValve.h
    • -4
    • +27
    /firmware/App/Modes/ModeStandby.c
2:12 pm

suresh

LDT-4049:Addressed review comments

Options
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.c
    • -6
    • +5
    /firmware/App/Modes/ModeStandby.c
    • -3
    • +1
    /firmware/App/Services/DDInterface.c
    • -1
    • +1
    /firmware/App/Services/DDInterface.h
11:39 am

Vendor - TEL - Varshini Nagabooshanam

Changes

Options
    • -40
    • +84
    /firmware/App/Drivers/PinchValve.c
    • -1
    • +1
    /firmware/App/Drivers/PinchValve.h
    • -0
    • +8
    /firmware/App/Modes/ModeStandby.c
Thursday 23 Jul
5:57 pm

Vendor - TEL - Varshini Nagabooshanam

Changes

Options
    • -29
    • +35
    /firmware/App/Drivers/PinchValve.c
3:45 pm

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'LDT-4149-pinch-valves-fw-implementation' of bitbucket.org:diality-cloud/td-firmware into LDT-4149-pinch-valves-fw-implementation

Options
    • -0
    • +6
    /firmware/App/Drivers/PinchValve.c
3:34 pm

Vendor - TEL - Varshini Nagabooshanam

New Add ons

Options
    • -140
    • +266
    /firmware/App/Drivers/PinchValve.c
    • -0
    • +3
    /firmware/App/Drivers/PinchValve.h
1:33 pm

suresh

LDT:4063- addressed review comments and updated the shutdown flag prompt

Options
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.c
    • -7
    • +4
    /firmware/App/Modes/OperationModes.c
    • -10
    • +2
    /firmware/App/Monitors/Buttons.c
1:31 pm

Vendor - TEL - Vijay Pamula

LDT-4029:Addressed review comments

Options
    • -14
    • +27
    /firmware/App/Controllers/SyringePump.c
    • -0
    • +1
    /firmware/App/Controllers/SyringePump.h
    • -4
    • +2
    /firmware/App/Modes/ModePreTreat.c
12:56 pm

Sean Nash

LDT-4149: Initialized ABC valve positions array.

Options
    • -0
    • +6
    /firmware/App/Drivers/PinchValve.c
11:48 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

11:48 am

Vendor - TEL - Arpita Srivastava

recircPublishTimerCtr is an output

recircPublishTimerCtr is an output

11:46 am

Vendor - TEL - Arpita Srivastava

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

11:44 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

11:40 am

Vendor - TEL - Arpita Srivastava

Initialization missing for the following variables in the init function. startRecircRequested reconnectRequested backToTreatmentRequested resumeRecircRequested

Initialization missing for the following variables in the init function.

startRecircRequested
reconnectRequested
backToTreatmentRequested
resumeRecircRequested

11:32 am

Vendor - TEL - Praneeth Bunne

All signal flags are initialized in resetSignalFlags() which we are calling below

All signal flags are initialized in resetSignalFlags() which we are calling below

11:27 am

Sean Nash

LDT-4149: more changes.

Options
    • -1
    • +24
    /firmware/App/Drivers/PinchValve.c
11:23 am

Vendor - TEL - Arpita Srivastava

please update the alarm id reservation sheet.

please update the alarm id reservation sheet.

11:20 am

Vendor - TEL - Arpita Srivastava

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out? Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out?
Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

11:15 am

Vendor - TEL - Arpita Srivastava

break this line : one variable per line will be easy to read.

break this line : one variable per line will be easy to read.

11:13 am

Vendor - TEL - Arpita Srivastava

StateTxRecirc should be above StateTxRinseback

StateTxRecirc should be above StateTxRinseback

11:07 am

Vendor - TEL - Arpita Srivastava

Add @Alarm ALARM_ID_TD_SALINE_BAG_VOLUME_LOW_ALARM

Add @Alarm ALARM_ID_TD_SALINE_BAG_VOLUME_LOW_ALARM

11:05 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

11:05 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

11:04 am

Vendor - TEL - Arpita Srivastava

Add rinsebackPublishTimerCtr to outputs

Add rinsebackPublishTimerCtr to outputs