td-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'LDT-4149-pinch-valves-fw-implementation' of bitbucket.org:diality-cloud/td-firmware into LDT-4149-pinch-valves-fw-implementation

LDT-4149: Increased valve speed. Added valve position change events.

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

While you are updating this file, can please break this line?

While you are updating this file, can please break this line?

Can we align like this result = u32BroadcastIntervalOverride( message, &preTreatmentStatePublishInterval, TASK_GENERAL_INTERVAL );

Can we align like this
result = u32BroadcastIntervalOverride( message,
&preTreatmentStatePublishInterval,
TASK_GENERAL_INTERVAL );

Add to inputs: preTreatmentStatePublishInterval

Add to inputs: preTreatmentStatePublishInterval

and break the line

and break the line

assign result to a variable and then return and break the line

assign result to a variable and then return and break the line

break this line

break this line

input is none

input is none

break this line

break this line

assign this to a variable and then return the variable. break this line

assign this to a variable and then return the variable.

break this line

Can we align = from line 270 to 281?

Can we align = from line 270 to 281?

break lines of this function to match our standard of 100 columns.

break lines of this function to match our standard of 100 columns.

break lines of this function to match our standard of 100 columns.

break lines of this function to match our standard of 100 columns.

input is none

input is none

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Merge branch 'LDT-4149-pinch-valves-fw-implementation' into develop

can we define this as NUM_OF_BATTERY_REGISTERS = BATTERY_END_OF_LIST_TIME_TO_PUBLISH, and use NUM_OF_BATTERY_REGISTERS everywhere instead of using [ NUM_OF_BATTERY_REGISTERS - 1 ]

can we define this as NUM_OF_BATTERY_REGISTERS = BATTERY_END_OF_LIST_TIME_TO_PUBLISH,

and use NUM_OF_BATTERY_REGISTERS everywhere instead of using [ NUM_OF_BATTERY_REGISTERS - 1 ]

break this line

break this line

align all the comments to line 57

align all the comments to line 57

Add Comments for line 43 to 50 and align all the comments of this section to line 38.

Add Comments for line 43 to 50 and align all the comments of this section to line 38.

add a blank line above

add a blank line above

add a blank line above

add a blank line above

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Add space in [registerSel]

Add space in [registerSel]

break this line

break this line

add a blank line above

add a blank line above

break this line

break this line