Activity td-firmware/

4:55 pm

Vendor - TEL - Varshini Nagabooshanam

More
cb993d8
changed 1 file
LDT-4149-pinch-valves-fw-implementation LEAHI-TD-FIRMWARE-LDT-4149-1

Changes

- -6
- +5
/firmware/App/Drivers/PinchValve.c
- History
- Source
- Diff
/firmware/App/Drivers/PinchValve.c

4:54 pm

Vendor - TEL - Arpita Srivastava and Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-4063-1
finished reviewing

4:47 pm

Vendor - TEL - Praneeth Bunne

More
37b3e39
changed 1 file
LDT-4040-rinseback LEAHI-TD-FIRMWARE-LDT-4040-1

LDT-4040: Resolve CR comments

- -3
- +2
/firmware/App/Modes/StateTxBloodPrime.c
- History
- Source
- Diff
/firmware/App/Modes/StateTxBloodPrime.c

4:27 pm

suresh

More
8c27b2b
changed 2 files
LDT-4063-power-control-and-post---fw-imp, LDT-4072-power-loss---fw-implementation-, staging LEAHI-TD-FIRMWARE-LDT-4063-1

aligned with Messaging.c

- -1
- +1
/firmware/App/Modes/OperationModes.h
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.h
- -5
- +4
/firmware/App/Services/Messaging.h
- History
- Source
- Diff
/firmware/App/Services/Messaging.h

4:11 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4072-2
commented on review

Why are we changing the rank of an existing alarm?

4:10 pm

Vendor - TEL - Varshini Nagabooshanam

More
a70cb02
changed 4 files
LDT-4149-pinch-valves-fw-implementation LEAHI-TD-FIRMWARE-LDT-4149-1

Merge branch 'staging' of bitbucket.org:diality-cloud/td-firmware into LDT-4149-pinch-valves-fw-implementation

- -21
- +181
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -3
- +4
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -1
- +3
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c
- -1
- +1
/firmware/App/TDCommon.h
- History
- Source
- Diff
/firmware/App/TDCommon.h

4:09 pm

Vendor - TEL - Varshini Nagabooshanam

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
replied to Vendor - TEL - Arpita Srivastava

Removed

4:08 pm

Vendor - TEL - Varshini Nagabooshanam

More
9b65dd8
changed 1 file
LDT-4033-patient-vitals-fw-implementation LEAHI-TD-FIRMWARE-LDT-4033-1

Changes

- -4
- +4
/firmware/App/Services/FpgaTD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaTD.c

4:08 pm

Vendor - TEL - Varshini Nagabooshanam

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
replied to Vendor - TEL - Arpita Srivastava

Fixed

4:07 pm

Vendor - TEL - Varshini Nagabooshanam

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
replied to Vendor - TEL - Arpita Srivastava

Fixed

4:07 pm

Vendor - TEL - Varshini Nagabooshanam

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
replied to Vendor - TEL - Arpita Srivastava

Fixed

4:07 pm

Vendor - TEL - Varshini Nagabooshanam

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
replied to Vendor - TEL - Arpita Srivastava

Fixed

4:07 pm

Vendor - TEL - Varshini Nagabooshanam

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
replied to Vendor - TEL - Arpita Srivastava

Fixed

4:07 pm

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-4033-1
resumed reviewing

4:07 pm

Vendor - TEL - Varshini Nagabooshanam

More
Re: LEAHI-TD-FIRMWARE-LDT-4033-1
replied to Vendor - TEL - Arpita Srivastava

Fixed

4:07 pm

Vendor - TEL - Varshini Nagabooshanam

More
f4383c9
changed 2 files
LDT-4033-patient-vitals-fw-implementation LEAHI-TD-FIRMWARE-LDT-4033-1

Changes

- -1
- +0
/firmware/App/Modes/ModeTreatment.c
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatment.c
- -12
- +12
/firmware/App/Services/FpgaTD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaTD.c

4:01 pm

Vendor - TEL - Varshini Nagabooshanam

More
371b499
changed 1 file
LDT-4033-patient-vitals-fw-implementation LEAHI-TD-FIRMWARE-LDT-4033-1

Merge branch 'staging' of bitbucket.org:diality-cloud/td-firmware into LDT-4033-patient-vitals-fw-implementation

- -1
- +3
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

4:01 pm

Vendor - TEL - Varshini Nagabooshanam

More
17261d7
changed 2 files
LDT-4149-pinch-valves-fw-implementation LEAHI-TD-FIRMWARE-LDT-4149-1

Changes

- -10
- +10
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c
- -157
- +189
/firmware/App/Drivers/PinchValve.c
- History
- Source
- Diff
/firmware/App/Drivers/PinchValve.c

3:58 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

These new functions should be above the test functions. Please align with the Messaging.c file. It looks correct in the Messaging.c file.

These new functions should be above the test functions.

Please align with the Messaging.c file.
It looks correct in the Messaging.c file.

3:54 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

Move this above the test functions.

3:50 pm

suresh

More
78e398b
changed 1 file
LDT-4063-power-control-and-post---fw-imp, LDT-4072-power-loss---fw-implementation-, staging LEAHI-TD-FIRMWARE-LDT-4063-1

Removed header

- -1
- +0
/firmware/App/Services/Messaging.h
- History
- Source
- Diff
/firmware/App/Services/Messaging.h

3:45 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

What is the use case of this header include?

3:36 pm

suresh

More
4db3ead
changed 2 files
LDT-4063-power-control-and-post---fw-imp, LDT-4072-power-loss---fw-implementation-, staging LEAHI-TD-FIRMWARE-LDT-4063-1

Fixed merge conflicts

- -1
- +3
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c
- -2
- +15
/firmware/App/Services/Messaging.h
- History
- Source
- Diff
/firmware/App/Services/Messaging.h

3:33 pm