td-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-4029:Addressed review comments

    • -2
    • +4
    /firmware/App/Modes/StatePreTxHeparinSetup.c
Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Merge branch 'LDT-5364-td-uf-update' into develop

    • -2
    • +17
    /firmware/App/Modes/StateTxDialysis.c
LDT-5364 uf progress update

    • -2
    • +17
    /firmware/App/Modes/StateTxDialysis.c
Missing some disinfects.

Missing some disinfects.

Move up after HCOL

Move up after HCOL

Add to inputs : heparinSetupResumeRequested

Add to inputs : heparinSetupResumeRequested

Add @alarm

Add @alarm

Add to inputs : interruptedPreTxHeparinSetupState

Add to inputs : interruptedPreTxHeparinSetupState

LDT-4049:Added msg handlers for DD disinfection state

    • -0
    • +194
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +21
    /firmware/App/Services/DDInterface.c
LDT-4029:Merge latest staging

    • -2
    • +2
    /firmware/App/Controllers/SyringePump.h
    • -21
    • +182
    /firmware/App/Modes/ModePreTreat.c
    • -1
    • +1
    /firmware/App/Modes/StatePreTxHeparinSetup.c
    • -4
    • +49
    /firmware/App/Services/AlarmMgmtTD.c
Add ons

    • -31
    • +59
    /firmware/App/Modes/ModeStandby.c
Remove blank line.

Remove blank line.

Still there.

Still there.

Remove if not needed.

Remove if not needed.

Why commented out? If not needed, delete.

Why commented out? If not needed, delete.

Use if/else or ternary to set result to TRUE or FALSE explicitly.

Use if/else or ternary to set result to TRUE or FALSE explicitly.

Added handlers for the states

    • -25
    • +84
    /firmware/App/Modes/ModePostTreat.c
    • -21
    • +123
    /firmware/App/Services/Messaging.c
Remove extra blank line.

Remove extra blank line.

Fix indent for break. Add comment before break "// unhandled command - do nothing.

Fix indent for break. Add comment before break "// unhandled command - do nothing.

Fix indent for break. Add comment before break "// unhandled position - do nothing.

Fix indent for break. Add comment before break "// unhandled position - do nothing.

Do we need this code? Can we delete it?

Do we need this code? Can we delete it?

Remove extra blank line.

Remove extra blank line.

Change these comments (H1 and H19 home arrays) to something like "Command list for H1 homing function."

Change these comments (H1 and H19 home arrays) to something like "Command list for H1 homing function."

Change comment to "Command list for pinch valve position change function."

Change comment to "Command list for pinch valve position change function."

Add a space before &

Add a space before &

LDT-4029:Updated heparin setup state

    • -2
    • +2
    /firmware/App/Modes/StatePreTxHeparinSetup.c
LDT-4029:Updated Heparin setup state

    • -0
    • +1
    /firmware/App/Controllers/SyringePump.c
    • -5
    • +13
    /firmware/App/Modes/StatePreTxHeparinSetup.c
Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.