Activity td-firmware/firmware/App/Controllers

What if we're in paused state (because your alarm has stop property set)? Should we return TRUE here if in paused state and interrupted state was the await syringe load confirmation state?

2 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4029-1
commented on review

Right now, the load syringe alarm indicates stop so we will go to paused state. Is that what we want to do? Don't we want to stay in this state and wait for confirmation?

2 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4029-1
commented on review

Should this alarm have stop property set to FALSE?

12:23 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

More
LEAHI-TD-FIRMWARE-LDT-4033-1
finished reviewing

11:34 am

Dara Navaei

More
LEAHI-TD-FIRMWARE-LDT-5358-1
started review

LEAHI-TD-FIRMWARE-LDT-5358_Pre-Treatment - FW Implementation - 10/6:

11:16 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

align comment

11:10 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-5214-1
commented on review

Can we please break this line as to match our standard of 100 columns? SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_AIR_PUMP_STALL, currentAirPumpPowerLevel, getU32OverrideValue( &currentAirPumpRPM ) );

Can we please break this line as to match our standard of 100 columns?

SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_AIR_PUMP_STALL,
currentAirPumpPowerLevel,
getU32OverrideValue( &currentAirPumpRPM ) );

10:22 am

Vendor - TEL - Varshini Nagabooshanam

More
7bb4651
changed 4 files
LDT-4149-pinch-valves-fw-implementation LEAHI-TD-FIRMWARE-LDT-4149-1

Changes

- -9
- +6
./Valves.c
- History
- Source
- Diff
./Valves.c
… 3 more files in changeset.

10:13 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

When we send any message to UI, usually add the message id in the doxygen header like this. @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the function s...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

9:55 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

It looks like the rows may be misaligned with the alarm ID declarations. For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

It looks like the rows may be misaligned with the alarm ID declarations.
For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

9:53 am