BloodFlow.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
done.

done.

Update I/O section here to include rotor revs accumulated and previous.

Update I/O section here to include rotor revs accumulated and previous.

handled accordingly.

handled accordingly.

removed and added.

removed and added.

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

I think this whole function should be moved to the PeristalticPump.c driver unit. We don't want controller/monitor level units directly accessing fpga registers - the drivers should be doing that.

I think this whole function should be moved to the PeristalticPump.c driver unit. We don't want controller/monitor level units directly accessing fpga registers - the drivers should be doing that.

LEAHI-TD-FIRMWARE-LDT-1394_Blood Flow Rate - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1394_Blood Flow Rate - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
Updated.

Updated.

Yes, we need to

Yes, we need to

Deleted.

Deleted.

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

Yes, I deleted.

Yes, I deleted.

Deleted.

Deleted.

Removed

Removed

Deleted.

Deleted.

Remove extra blank line.

Remove extra blank line.

MODE_TPAR should be deleted.

MODE_TPAR should be deleted.

It should no longer be called from OperationModes.c because we are deleted the TxParams mode (delete from enum and any switch statements in OperationModes.c).

It should no longer be called from OperationModes.c because we are deleted the TxParams mode (delete from enum and any switch statements in OperationModes.c).

ModeTxParams.c/.h are still not deleted. I want you to delete them and commit/push that change. Then I will see both files in RED here in this CR.

ModeTxParams.c/.h are still not deleted. I want you to delete them and commit/push that change. Then I will see both files in RED here in this CR.

Thanks for the clarification. This handler already follows the single-parameter MESSAGE_T *message pattern, and the message ID is already defined and registered in Messaging.c. I’ll keep using the ...

Thanks for the clarification. This handler already follows the single-parameter MESSAGE_T *message pattern, and the message ID is already defined and registered in Messaging.c. I’ll keep using the existing ID, ensure payload length is validated, and parse the param/value from the payload as expected.

Yes, this is called in OperationModes.c

Yes, this is called in OperationModes.c

Sure.

Sure.

Added.

Added.

Added.

Added.

I didn't see this in header file.

I didn't see this in header file.