LevelSensors.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 94 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 95 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 90 more files in changeset.
TD-LEAH-838_FW TD Gas Liquid Transfer Pump
TD-LEAH-838_FW TD Gas Liquid Transfer Pump
LEAH-838: Addressed code review feedback.

  1. … 17 more files in changeset.
Done.

Done.

Fixed.

Fixed.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

I would say we are required to explicitly typecast if any of the following are true: 1) compiler warning if you don't 2) byte count/mem size matters (e.g. message payload) and might not match desir...

I would say we are required to explicitly typecast if any of the following are true:
1) compiler warning if you don't
2) byte count/mem size matters (e.g. message payload) and might not match desired size if you don't cast it

I don't think either is true in this case.

Removed TODO.

Removed TODO.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Yes. Done.

Yes. Done.

Change has not happened yet in Denali. I will follow up with Dara after change is made.

Change has not happened yet in Denali. I will follow up with Dara after change is made.

Done.

Done.

Do we want to change STATE_CLOSED to CMN_TO_NO_OPEN (or similar?), STATE_OPEN to CMN _TO_NC_OPEN?

Do we want to change STATE_CLOSED to CMN_TO_NO_OPEN (or similar?), STATE_OPEN to CMN _TO_NC_OPEN?

3-way

3-way

May be add a check to validate the power level between 0 to 255.

May be add a check to validate the power level between 0 to 255.

No Alarm, Add Event ID.

No Alarm, Add Event ID.

MotorState to MotorPowerLevel - across file.

MotorState to MotorPowerLevel - across file.

Please adjust the alignment(few #defines)

Please adjust the alignment(few #defines)