td-firmware / firmware / App / Drivers

Valve2Way.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 1
Last Commit: 14:44
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 24 Feb
3:26 pm

Sean Nash

1:46 pm

Vinayakam Mani and Michael Garthwaite

1:22 pm

Sean Nash

TD-LEAH-838_FW TD Gas Liquid Transfer Pump
TD-LEAH-838_FW TD Gas Liquid Transfer Pump
Friday 21 Feb
3:02 pm

Sean Nash

Done.

Done.

2:42 pm

Sean Nash

Fixed.

Fixed.

2:42 pm

Sean Nash

Done.

Done.

2:38 pm

Sean Nash

Done.

Done.

2:36 pm

Sean Nash

Done.

Done.

2:34 pm

Sean Nash

Done.

Done.

2:32 pm

Sean Nash

Done.

Done.

2:30 pm

Sean Nash

Done.

Done.

2:28 pm

Sean Nash

I would say we are required to explicitly typecast if any of the following are true: 1) compiler warning if you don't 2) byte count/mem size matters (e.g. message payload) and might not match desir...

I would say we are required to explicitly typecast if any of the following are true:
1) compiler warning if you don't
2) byte count/mem size matters (e.g. message payload) and might not match desired size if you don't cast it

I don't think either is true in this case.

2:25 pm

Sean Nash

Removed TODO.

Removed TODO.

2:23 pm

Sean Nash

Done.

Done.

2:14 pm

Sean Nash

Done.

Done.

2:13 pm

Sean Nash

Done.

Done.

2:11 pm

Sean Nash

Done.

Done.

2:10 pm

Sean Nash

Yes. Done.

Yes. Done.

2:09 pm

Sean Nash

Change has not happened yet in Denali. I will follow up with Dara after change is made.

Change has not happened yet in Denali. I will follow up with Dara after change is made.

2:00 pm

Sean Nash

Done.

Done.

Thursday 20 Feb
4:08 pm

Vinayakam Mani

Do we want to change STATE_CLOSED to CMN_TO_NO_OPEN (or similar?), STATE_OPEN to CMN _TO_NC_OPEN?

Do we want to change STATE_CLOSED to CMN_TO_NO_OPEN (or similar?), STATE_OPEN to CMN _TO_NC_OPEN?

3:57 pm

Vinayakam Mani

3-way

3-way

3:51 pm

Vinayakam Mani

May be add a check to validate the power level between 0 to 255.

May be add a check to validate the power level between 0 to 255.

3:49 pm

Vinayakam Mani

No Alarm, Add Event ID.

No Alarm, Add Event ID.

3:48 pm

Vinayakam Mani

MotorState to MotorPowerLevel - across file.

MotorState to MotorPowerLevel - across file.

3:39 pm

Vinayakam Mani

Please adjust the alignment(few #defines)

Please adjust the alignment(few #defines)

3:34 pm

Vinayakam Mani

isAutoControlling?

isAutoControlling?

3:31 pm

Vinayakam Mani

please add description/details along with the Message ID

please add description/details along with the Message ID

3:30 pm

Vinayakam Mani

Do we need explicit typecast to U32?

Do we need explicit typecast to U32?

3:20 pm

Vinayakam Mani

#define the 1 and 0.

#define the 1 and 0.