Activity td-firmware/firmware/App/Drivers/Valve3Way.h

9:44 am

Dara Navaei

More
e24a98a
changed 96 files
develop

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -5
- +5
./Valve3Way.h
- History
- Source
- Diff
./Valve3Way.h
… 95 more files in changeset.

8:35 pm

Dara Navaei

More
fe136db
changed 91 files
BambooSetup

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -5
- +5
./Valve3Way.h
- History
- Source
- Diff
./Valve3Way.h
… 90 more files in changeset.

3:26 pm

Vinayakam Mani and Michael Garthwaite

More
TD-LEAH-838-1
finished reviewing

1:22 pm

Sean Nash

More
TD-LEAH-838-1
started review

TD-LEAH-838_FW TD Gas Liquid Transfer Pump

3:03 pm

Sean Nash

More
285b5d8
changed 18 files
BambooSetup, LDT-1735-test-config-support-for-dd and 24 more TD-LEAH-838-1

LEAH-838: Addressed code review feedback.

- -2
- +2
./Valve3Way.h
- History
- Source
- Diff
./Valve3Way.h
… 17 more files in changeset.

3:02 pm

I would say we are required to explicitly typecast if any of the following are true: 1) compiler warning if you don't 2) byte count/mem size matters (e.g. message payload) and might not match desir...

I would say we are required to explicitly typecast if any of the following are true:
1) compiler warning if you don't
2) byte count/mem size matters (e.g. message payload) and might not match desired size if you don't cast it

I don't think either is true in this case.

2:25 pm