ModeTreatment.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
documentation error- is it transition start time ?

documentation error- is it transition start time ?

Done

Done

Then put an #if 0 around this if and add a TODO comment to implement the test configuration.

Then put an #if 0 around this if and add a TODO comment to implement the test configuration.

Done

Done

Done

Done

None?

None?

None?

None?

I don't see this input used in function.

I don't see this input used in function.

Done

Done

Done

Done

Done

Done

The checks are back in a generic function.

The checks are back in a generic function.

Done

Done

Done

Done

The test configuration has not been imported yet. I commented it out as a placeholder.

The test configuration has not been imported yet. I commented it out as a placeholder.

Done

Done

Done

Done

Done

Done

Done

Done

Do you mean to delete this function?

Do you mean to delete this function?

I mean, don't you think Sarina/Eliza still want this test config option? Why did you comment it out?

I mean, don't you think Sarina/Eliza still want this test config option? Why did you comment it out?

Make 10000 a #define.

Make 10000 a #define.

Ok, but then I think the valves controller should be calling a function in this driver to accomplish this kind of thing since it's a driver level activity.

Ok, but then I think the valves controller should be calling a function in this driver to accomplish this kind of thing since it's a driver level activity.

I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing).

I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing).

I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing).

I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing).