td-firmware / firmware / App

Monitors

Clone Tools

Stats

Commits this week: 3
Total Committers: 8
Last Commit: 16:37
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Sean Nash

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

3 hrs ago

Sean Nash

2 lines above/below banner

2 lines above/below banner

3 hrs ago

Sean Nash

remove blank line.

remove blank line.

4 hrs ago

Sean Nash

use response.x for these.

use response.x for these.

4 hrs ago

Sean Nash

use response.duration.

use response.duration.

4 hrs ago

Sean Nash

Already set this above.

Already set this above.

Sunday 03 May
11:17 pm

Sean Nash

I don't think we should change this.

I don't think we should change this.

11:15 pm

Sean Nash

Not sure this makes sense. Time is in minutes. min * mL/min = mL (makes sense). min * L/hr = minL/hr (does not make sense). Talk to Raghu about UF rate units and when we should use mL/min vs. L/hr.

Not sure this makes sense. Time is in minutes. min * mL/min = mL (makes sense). min * L/hr = minL/hr (does not make sense).
Talk to Raghu about UF rate units and when we should use mL/min vs. L/hr.

Friday 01 May
10:05 am

Raghu Kallala

LDT-4188 resolved merge conflicts on develop

Options
    • -2
    • +2
    ./Pressures.c
  2. … 2 more files in changeset.
Thursday 30 Apr
3:57 pm

Sean Nash

I don't think you want stored (old) value here. You want value from first message before confirmation.

I don't think you want stored (old) value here. You want value from first message before confirmation.

Wednesday 29 Apr
11:02 am

Raghu Kallala

LDT-473 resolved merge conflict with develop

Options
    • -4
    • +4
    ./Pressures.c
  2. … 2 more files in changeset.
11:02 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Pressures.c
  2. … 11 more files in changeset.
10:57 am

Raghu Kallala

10:44 am

Vinayakam Mani

9:57 am

Sean Nash

Keep 2 blank lines above the banner below.

Keep 2 blank lines above the banner below.

9:56 am

Sean Nash

Is this still needed?

Is this still needed?

9:56 am

Sean Nash

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

9:49 am

Sean Nash

Keep 2 blank lines above the test support functions banner.

Keep 2 blank lines above the test support functions banner.

9:47 am

Sean Nash

Not sure why you are making changes to this function. This function handles message from UI to pause or resume ultrafiltration. This is not a treatment parameter edit message, so I don't think it's...

Not sure why you are making changes to this function.
This function handles message from UI to pause or resume ultrafiltration.
This is not a treatment parameter edit message, so I don't think it's part of your assignment.

9:43 am

Sean Nash

No longer needed?

No longer needed?

9:42 am

Sean Nash

9:42 am

Sean Nash

Tuesday 28 Apr
9:13 pm

Vendor - TEL - Vijay Pamula

LDT-3970: remove extra whitespace and blank lines

Options
    • -1
    • +0
    ./Pressures.h
  2. … 1 more file in changeset.
8:33 pm

Vendor - TEL - Vijay Pamula

LDT-3970: Adressed code review comments

Options
    • -169
    • +0
    ./Pressures.c
    • -1
    • +1
    ./Pressures.h
  3. … 7 more files in changeset.
6:13 pm

Sean Nash

2:31 pm

Sean Nash

???

???

2:30 pm

Sean Nash

Do we need a parameter for confirmation?

Do we need a parameter for confirmation?

Sunday 26 Apr
1:08 pm

Sean Nash

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

1:06 pm

Sean Nash

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

1:02 pm

Sean Nash

These are already in TxParams I believe.

These are already in TxParams I believe.