FpgaTD.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 5 more files in changeset.
done updated below in the function as well.

done updated below in the function as well.

done.

done.

LDT-1394 addressed code review comments

  1. … 1 more file in changeset.
Intentional?

Intentional?

update the header and field comments in later commits

update the header and field comments in later commits

Merge branch 'staging' into LDT-1394-blood-flow-rate-h4-rotor-count

  1. … 1 more file in changeset.
If we don't think we need this, let's just delete it. If we think it's coming back, let's keep it and just set the max count to something really high (e.g. 1,000,000).

If we don't think we need this, let's just delete it. If we think it's coming back, let's keep it and just set the max count to something really high (e.g. 1,000,000).

blank line before return.

blank line before return.

Blank line after declarations.

Blank line after declarations.

Merge branch LDT-1903-air-trap-level-control-delay-adjust-after-fill-fix---td---0 into branch develop

  1. … 3 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 8 more files in changeset.
Merge branch 'LDT-1394-blood-flow-rate-h4-rotor-count' into develop

  1. … 1 more file in changeset.
done.

done.

Update I/O section here to include rotor revs accumulated and previous.

Update I/O section here to include rotor revs accumulated and previous.

handled accordingly.

handled accordingly.

removed and added.

removed and added.

LDT-1394 addressed code review comments

  1. … 3 more files in changeset.
fixed in latest code

fixed in latest code

implemented

implemented

fixed

fixed

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

I think this whole function should be moved to the PeristalticPump.c driver unit. We don't want controller/monitor level units directly accessing fpga registers - the drivers should be doing that.

I think this whole function should be moved to the PeristalticPump.c driver unit. We don't want controller/monitor level units directly accessing fpga registers - the drivers should be doing that.

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

LDT-1394 added h4 rotor revs count for broadcasting it

  1. … 2 more files in changeset.