Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
Yes, we do and this is not required here so, I removed

Yes, we do and this is not required here so, I removed

Shouldn't we be getting these defaults from the TxParams unit?

Shouldn't we be getting these defaults from the TxParams unit?

Yes, Updated

Yes, Updated

I think this should be commented out before we merge to staging.

I think this should be commented out before we merge to staging.

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
Updated

Updated

Updated

Updated

Format for params is: param name description Add "psi" (name) between param and "Pressure value in PSI".

Format for params is: param name description
Add "psi" (name) between param and "Pressure value in PSI".

I removed

I removed

Sorry, updated

Sorry, updated

Updated

Updated

Updated

Updated

Add space between = and (F32)

Add space between = and (F32)

Yes we need to add

Yes we need to add

Added param looks wrong.

Added param looks wrong.

Align | separators all the way to right end of these 2 rows.

Align | separators all the way to right end of these 2 rows.

No, by mistake I copy pasted the same

No, by mistake I copy pasted the same

Added

Added

Added

Added

Updated

Updated

Updated

Updated

Updated

Updated

Sorry, Updated

Sorry, Updated

You added them, but you're not really using them and you're not using the tmp override either as far as I can see. Do we need any of these?

You added them, but you're not really using them and you're not using the tmp override either as far as I can see. Do we need any of these?

I don't see it.

I don't see it.

Fix spelling in comment (membrane should not have a 'c' in it).

Fix spelling in comment (membrane should not have a 'c' in it).