Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

Why do we need this?

Remove extra blank line.

Remove extra blank line.

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above.
What does nr stand for?

Let's remove this commented line.

I don't need to edit this file. I will check with Dara to exclude this file from code review.

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals.
need to split it or need two message id.

Its a problem . Vinay has to decide it

Delete the macro if not being used.

removed

updated comment.

removed.

removed and added comments.

changed.

done. moved them to dosing concentrates state.

Balancing chamber switching control

remove the space before false.

Remove blank line

Remove blank line.

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

Remove this reference (across the file) if the implementation is updated.