· /firmware/App/Controllers/BalancingChamber.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/BoostPump.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/BoostPump.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DialysatePumps.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DialysatePumps.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/PermeateTank.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/PermeateTank.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-3, +3)	| History	| Source	| Diff
… 107 more files in changeset.

]]> Tue, 09 Dec 2025 11:24:33 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2329-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2329-2 Dara Navaei Closed LEAHI-DD-FIRMWARE-LDT-2329-2 ]]> Tue, 09 Dec 2025 11:20:42 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2329-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2329-2 Sean Nash and Vendor - TEL - Sameer Poyil finished reviewing LEAHI-DD-FIRMWARE-LDT-2329-2 LEAHI-DD-FIRMWARE-LDT-2329_(DD) Concentrate Pumps Measured Speed Does Not Equal Target Set Speed ]]> Tue, 09 Dec 2025 11:19:31 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2329-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2329-2 Dara Navaei removed jpaguio  (deleted user) from LEAHI-DD-FIRMWARE-LDT-2329-2 LEAHI-DD-FIRMWARE-LDT-2329_(DD) Concentrate Pumps Measured Speed Does Not Equal Target Set Speed ]]> Tue, 09 Dec 2025 11:15:35 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2329-2/#c25668 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2329-2/#c25668 Dara Navaei replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-2329-2

Done

comments should start with capital letter

· /firmware/App/Controllers/BalancingChamber.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/BoostPump.c	(-6, +6)	| History	| Source	| Diff
· /firmware/App/Controllers/BoostPump.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DialysatePumps.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/DialysatePumps.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/PermeateTank.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/PermeateTank.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-3, +3)	| History	| Source	| Diff
… 107 more files in changeset.

]]> Fri, 14 Nov 2025 17:03:52 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2662-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2662-1 Sean Nash Closed LEAHI-DD-FIRMWARE-LDT-2662-1 ]]> Fri, 14 Nov 2025 15:19:51 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2662-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2662-1 Raghu Kallala , Vinayakam Mani and Dara Navaei finished reviewing LEAHI-DD-FIRMWARE-LDT-2662-1 LEAHI-DD-FIRMWARE-LDT-2662_Beta 1.0 FW Integration Part 2 - DD Implementation ]]> Fri, 14 Nov 2025 11:24:25 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2662-1/#c25161 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2662-1/#c25161 Dara Navaei replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2662-1

Done

No I removed it.

I will resolve this for now, but I don't think ACKs are necessary and I'm pretty sure TD is not looking for a response. TD may be waiting for DD to change mode by looking at DD mode broadcasts.

· /firmware/.settings/org.eclipse.core.resources.prefs	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DialysatePumps.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/SpentChamberFill.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-0, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-19, +49)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-4, +26)	| History	| Source	| Diff

]]> Thu, 13 Nov 2025 09:56:42 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2662-1/#c25133 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2662-1/#c25133 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2662-1

fixed. thanks

I think so. the TD needs to know if we are successful in stopping Gen mode for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

fixed. thanks

Ok, but see my next comment below. Do we need to ACK with a result at all? Does TD require this?

updated to now change result to FALSE if we get a rr that is not NONE

updated to now change result to FALSE if we get a rr that is not NONE

reworked to use the request stop functions in their respective op modes.

reworked to use the request functions we have in the respective op modes. They check the standby constraint

fixed. thanks!

fixed. thanks!

fixed. thanks!