LEAHI-DD-FIRMWARE-LDT-2662-1 LEAHI-DD-FIRMWARE-LDT-2662_Beta 1.0 FW Integration Part 2 - DD Implementation

closed on 14 Nov

Author

Moderator

Reviewers

LEAHI-DD-FIRMWARE-LDT-2662_Beta 1.0 FW Integration Part 2 - DD Implementation

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 40

dd-firmware 0
- Folder firmware 0
  - Folder .settings 0
    - File org.eclipse.core.resources.prefs 0 Remove
  - Folder App 0
    - Folder Controllers 0
      - File ConcentratePumps.c 0 Remove
      - File DialysatePumps.c 0 Remove
      - File DialysatePumps.h 0 Remove
      - File PermeateTank.c 0 Remove
      - File SpentChamberFill.h 0 Remove
      - File Valves.c 0 Remove
      - File Valves.h 0 Remove
    - Folder Drivers 0
      - File PressureSensor.c 0 Remove
      - File PressureSensor.h 0 Remove
    - Folder Modes 0
      - Folder FPModes 0
        
        File FPModeFault.c 0 Remove
        
        File FPModeStandby.c 0 Remove
        
        File FPOperationModes.c 12 Remove
        
        File FPOperationModes.h 0 Remove
        
        File FlushConcentrate.c 0 Remove
        
        File FlushFilter.c 0 Remove
        
        File FlushPermeate.c 0 Remove
        
        File InletPressureCheck.c 0 Remove
        
        File ModeGenPermeateDefeatured.c 0 Remove
        
        File ModePreGenPermeate.c 0 Remove
        
        File ModePreGenPermeateDefeatured.c 0 Remove
      - File ModeGenDialysate.c 0 Remove
      - File ModeGenDialysate.h 0 Remove
    - Folder Monitors 0
      - File BloodLeak.c 4 Remove
      - File BloodLeak.h 4 Remove
      - File Level.c 3 Remove
      - File Pressure.c 0 Remove
      - File Pressure.h 0 Remove
      - File Temperature.c 0 Remove
      - File Temperature.h 0 Remove
      - File WaterQualityMonitor.c 4 Remove
      - File WaterQualityMonitor.h 0 Remove
    - Folder Services 0
      - File FpgaDD.c 0 Remove
      - File FpgaDD.h 0 Remove
      - File Messaging.c 2 Remove
      - File TDInterface.c 11 Remove
    - File DDCommon.h 0 Remove
leahi-common 0
- File AlarmDefs.h 0 Remove
- File DDDefs.h 0 Remove
- File MsgDefs.h 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Sean Nash	Author & Moderator	1h 34m	20	I will resolve this for now, but I don't think ACKs are n...
Dara Navaei	Reviewer - 96% reviewed	26m	4	Done
Vinayakam Mani	Reviewer - Complete	42m	1	Done.
Vendor - TEL - Sivvanarayana Kurapati	Reviewer - 3% reviewed	36m
Michael Garthwaite	Reviewer - 64% reviewed	35m	12	fixed. thanks
Vendor - TEL - Arpita Srivastava	Reviewer - 0% reviewed
Daniel Ho	Reviewer - 0% reviewed
Raghu Kallala	Reviewer - Complete	58m	3	Removed. Thanks
Vendor - TEL - Jashwant Gantyada	Reviewer - 28% reviewed	39m
Total		5h 33m	40

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-DD-FIRMWARE-LDT-2662-1

LEAHI-DD-FIRMWARE-LDT-2662_Beta 1.0 FW Integration Part 2 - DD Implementation

LEAHI-DD-FIRMWARE-LDT-2662-1 40

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAHI-DD-FIRMWARE-LDT-2662_Beta 1.0 FW Integration Part 2 - DD Implementation

LEAHI-DD-FIRMWARE-LDT-2662-1 40

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time