Done

comments should start with capital letter

Done

No I removed it.

I will resolve this for now, but I don't think ACKs are necessary and I'm pretty sure TD is not looking for a response. TD may be waiting for DD to change mode by looking at DD mode broadcasts.

fixed. thanks

I think so. the TD needs to know if we are successful in stopping Gen mode for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

fixed. thanks

Ok, but see my next comment below. Do we need to ACK with a result at all? Does TD require this?

updated to now change result to FALSE if we get a rr that is not NONE

updated to now change result to FALSE if we get a rr that is not NONE

reworked to use the request stop functions in their respective op modes.

reworked to use the request functions we have in the respective op modes. They check the standby constraint

fixed. thanks!

fixed. thanks!

fixed. thanks!

Can we remove it now (before we merge to staging)?

Is it still needed? If so, when do we expect it can be removed?

If we're not sending ACK here, let's remove this code and replace with a comment stating we are only ACKing Dialin messages.