Fisheye on dd-firmware/firmware/App/Controllers/Valves.h

LEAHI-DD-FIRMWARE-LDT-3627-1: closed by Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada — Fri, 03 Apr 2026 09:31:01 -0700

Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3627-1

LEAHI-DD-FIRMWARE-LDT-3627-1: reviewers finished

Fri, 03 Apr 2026 08:32:42 -0700

Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3627-1

LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1

LEAHI-DD-FIRMWARE-LDT-3627-1: reviewers finished

Thu, 02 Apr 2026 15:35:36 -0700

Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3627-1

LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1

LEAHI-DD-FIRMWARE-LDT-3627-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valv...

Tue, 31 Mar 2026 09:36:56 -0700

Sean Nash added Michael Garthwaite and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3627-1

LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1

LEAHI-DD-FIRMWARE-LDT-3218-4: started by Dara Navaei

Dara Navaei — Wed, 25 Mar 2026 11:16:55 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3218-4

LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei

Dara Navaei — Wed, 25 Mar 2026 04:01:46 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13

LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei

Dara Navaei — Thu, 19 Mar 2026 15:47:06 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11

LEAHI-DD-FIRMWARE-LDT-3627-1: started by Dara Navaei

Dara Navaei — Mon, 16 Mar 2026 13:52:13 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3627-1

LEAHI-DD-FIRMWARE-LDT-3552-1: closed by Dara Navaei

Dara Navaei — Fri, 20 Feb 2026 17:07:01 -0800

Dara Navaei Closed LEAHI-DD-FIRMWARE-LDT-3552-1

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 20 Feb 2026 15:12:22 -0800

Dara Navaei committed dc4b4fd on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 35 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Valves.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/BloodLeakDriver.h	(-2, +2)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-3552-1: reviewers finished

Fri, 20 Feb 2026 14:46:13 -0800

Vendor - TEL - Arpita Srivastava and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3552-1

LEAHI-DD-FIRMWARE-LDT-3552_The FW Message List generated aren't able to decode some messages

LEAHI-DD-FIRMWARE-LDT-3552-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3552_The FW Message List gen...

Fri, 20 Feb 2026 14:41:35 -0800

Sean Nash added Vendor - TEL - Arpita Srivastava to LEAHI-DD-FIRMWARE-LDT-3552-1

LEAHI-DD-FIRMWARE-LDT-3552_The FW Message List generated aren't able to decode some messages

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3552 updated the array of the DD valves structure

Dara Navaei — Thu, 19 Feb 2026 11:24:40 -0800

Dara Navaei committed 9163776 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 36 more in dd-firmware

LDT-3552 updated the array of the DD valves structure

· /firmware/App/Controllers/Valves.h

(-6, +1)

| History

| Source

| Diff

LEAHI-DD-FIRMWARE-LDT-3552-1: started by Dara Navaei

Dara Navaei — Tue, 17 Feb 2026 10:16:37 -0800

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3552-1

LEAHI-DD-FIRMWARE-LDT-3222-1: closed by Dara Navaei

Dara Navaei — Mon, 09 Feb 2026 13:39:04 -0800

Dara Navaei Closed LEAHI-DD-FIRMWARE-LDT-3222-1

LEAHI-DD-FIRMWARE-LDT-3222-1: reviewers finished

Mon, 09 Feb 2026 13:34:55 -0800

Sean Nash , Michael Garthwaite and Vendor - TEL - Sameer Poyil finished reviewing LEAHI-DD-FIRMWARE-LDT-3222-1

LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides

LEAHI-DD-FIRMWARE-LDT-3222-1: started by Dara Navaei

Dara Navaei — Mon, 09 Feb 2026 13:30:12 -0800

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3222-1

LEAHI-DD-FIRMWARE-LDT-3222-1: closed by Vendor - TEL - Arpita Srivastava

Vendor - TEL - Arpita Srivastava — Mon, 09 Feb 2026 10:59:36 -0800

Vendor - TEL - Arpita Srivastava Closed LEAHI-DD-FIRMWARE-LDT-3222-1

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 09 Feb 2026 09:36:40 -0800

Dara Navaei committed 23e8d8f on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 43 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Valves.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-2, +2)	\| History	\| Source	\| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Merge branch 'staging' of bitbucket.org:diality-cloud/dd-firmware into LDT-3222-command-to-override-all-BC

Vendor - TEL - Arpita Srivastava — Mon, 09 Feb 2026 09:28:22 -0800

Vendor - TEL - Arpita Srivastava committed 17bfea4 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 44 more in dd-firmware

Merge branch 'staging' of bitbucket.org:diality-cloud/dd-firmware into LDT-3222-command-to-override-all-BC

· /firmware/App/Controllers/Valves.c	(-2, +43)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-1, +11)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-3222-1: comment by Vinayakam Mani "This function sounds a duplicate of 'testValveS..."

Vinayakam Mani — Fri, 06 Feb 2026 15:16:11 -0800

Vinayakam Mani replied to Vendor - TEL - Arpita Srivastava in LEAHI-DD-FIRMWARE-LDT-3222-1

This function sounds a duplicate of 'testValveStateOverride' and not specifically in use. we can delete it.

LEAHI-DD-FIRMWARE-LDT-3222-1: comment by Vendor - TEL - Arpita Srivastava "The type of payload expected by the function u3..."

Vendor - TEL - Arpita Srivastava — Fri, 06 Feb 2026 14:04:33 -0800

Vendor - TEL - Arpita Srivastava replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3222-1

The type of payload expected by the function u32ArrayOverride is TEST_OVERRIDE_ARRAY_PAYLOAD_T whereas the type of payload received by the function testBCValveStatesOverride is DD_BC_VALVE_OVERRIDE_PAYLOAD_T. Because of the mismatch is payload type, we cannot use the function u32ArrayOverride in this case.

LEAHI-DD-FIRMWARE-LDT-3222-1: comment by Vendor - TEL - Arpita Srivastava "We can update this function as part of another ..."

Vendor - TEL - Arpita Srivastava — Fri, 06 Feb 2026 13:36:51 -0800

Vendor - TEL - Arpita Srivastava replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3222-1

We can update this function as part of another Jira ticket.

LEAHI-DD-FIRMWARE-LDT-3222-1: comment by Sean Nash "This one looks like maybe we could use the help..."

Sean Nash — Fri, 06 Feb 2026 13:21:13 -0800

Sean Nash replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-3222-1

This one looks like maybe we could use the helper function. Have Vinay look at it.

LEAHI-DD-FIRMWARE-LDT-3222-1: comment by Sean Nash "I don't think so. The state is bit encoded, so..."

Sean Nash — Fri, 06 Feb 2026 13:19:23 -0800

Sean Nash replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-3222-1

I don't think so. The state is bit encoded, so special handling is required.

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 04 Feb 2026 11:36:28 -0800

Dara Navaei committed b569bc7 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 44 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/PermeateTank.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/RinsePump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/TDInterface.c	(-2, +2)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-3343-1: closed by Raghu Kallala

Raghu Kallala — Wed, 04 Feb 2026 11:34:48 -0800

Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3343-1

LEAHI-DD-FIRMWARE-LDT-3343-1: reviewers finished

Wed, 04 Feb 2026 11:30:28 -0800

Sean Nash , Vinayakam Mani and Michael Garthwaite finished reviewing LEAHI-DD-FIRMWARE-LDT-3343-1

LEAHI-DD-FIRMWARE-LDT-3343_DD FW control stops IOFP manual control

LEAHI-DD-FIRMWARE-LDT-3343-1: comment by Raghu Kallala "Updated"

Raghu Kallala — Wed, 04 Feb 2026 06:24:10 -0800

Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3343-1

Updated

LEAHI-DD-FIRMWARE-LDT-3343-1: comment by Raghu Kallala "Fixed"

Raghu Kallala — Wed, 04 Feb 2026 06:23:26 -0800

Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3343-1

Fixed