Fisheye on dd-firmware/firmware/App/Controllers/RinsePump.h https://devapps.diality.us/changelog/~br%3DLDT-3103-implement-closed-loop-control-f/dd-firmware/firmware/App/Controllers/RinsePump.h Recent activity in "dd-firmware" under directory /firmware/App/Controllers/RinsePump.h LEAHI-DD-FIRMWARE-LDT-4246-1: started by Dara Navaei Wed, 06 May 2026 08:48:07 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4246-1 ]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Remove this flag." Tue, 05 May 2026 12:35:33 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28878 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28878 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Remove this flag.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Remove this code." Tue, 05 May 2026 12:31:12 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28877 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28877 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Remove this code.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Remove this condition to apply the speed for BC..." Tue, 05 May 2026 11:57:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28871 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28871 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Remove this condition to apply the speed for BC switch only as well.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Check the else portion and do the required chan..." Tue, 05 May 2026 10:20:37 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28823 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28823 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Check the else portion and do the required changes.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Name something similar to 'BCSwitchingBasedOnCl..." Mon, 04 May 2026 16:14:18 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28817 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28817 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "I guess, all these checks should be moved to Fi..." Mon, 04 May 2026 16:02:37 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28816 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28816 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

I guess, all these checks should be moved to FillEndState.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "after one state of BC switching completed. upda..." Mon, 04 May 2026 15:51:27 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28815 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28815 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

after one state of BC switching completed. update the next comment as well.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vendor - TEL - Arpita Srivastava "Should we add a TODO to remove this one as well..." Mon, 04 May 2026 09:59:06 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28813 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28813 Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Should we add a TODO to remove this one as well?

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vendor - TEL - Arpita Srivastava "If we are removing this call, then where are we..." Mon, 04 May 2026 09:57:11 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28812 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28812 Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-3963-1

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vendor - TEL - Arpita Srivastava "Please update the function name : testDDFloater..." Mon, 04 May 2026 09:44:11 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28811 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28811 Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Please update the function name : testDDFloaterLevelStateOverride

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - F... Sun, 03 May 2026 23:45:17 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Sean Nash added Michael Garthwaite , Vendor - TEL - Arpita Srivastava and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3963-1 LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3: ]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Why are we removing this TODO comment? It look..." Sun, 03 May 2026 23:08:20 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28783 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28783 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Why are we removing this TODO comment? It looks like we should keep it.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Do we need TODO comments to restore these alarm..." Sun, 03 May 2026 23:06:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28782 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28782 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Do we need TODO comments to restore these alarms later?

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "What is the point of this message?" Sun, 03 May 2026 23:06:01 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28781 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28781 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

What is the point of this message?

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Looks like we need a TODO comment to restore th..." Sun, 03 May 2026 23:01:28 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28780 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28780 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Looks like we need a TODO comment to restore these checks later.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "First two logics ANDed correct (first cycle and..." Tue, 28 Apr 2026 12:08:19 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28728 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28728 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Don't assign BOOL variables implicitly. Always..." Sun, 26 Apr 2026 12:42:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28652 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c28652 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: started by Dara Navaei Tue, 21 Apr 2026 09:17:58 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3963-1 ]]> LEAHI-DD-FIRMWARE-LDT-3627-1: closed by Vendor - TEL - Jashwant Gantyada Fri, 03 Apr 2026 09:31:01 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3627-1 ]]> LEAHI-DD-FIRMWARE-LDT-3627-1: reviewers finished Fri, 03 Apr 2026 08:32:42 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> LEAHI-DD-FIRMWARE-LDT-3627-1: reviewers finished Thu, 02 Apr 2026 15:35:36 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> LEAHI-DD-FIRMWARE-LDT-3627-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valv... Tue, 31 Mar 2026 09:36:56 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Sean Nash added Michael Garthwaite and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> LEAHI-DD-FIRMWARE-LDT-3627-1: started by Dara Navaei Mon, 16 Mar 2026 13:52:13 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3627-1 ]]> LEAHI-DD-FIRMWARE-LDT-3344-1: closed by Vendor - TEL - Jashwant Gantyada Tue, 24 Feb 2026 11:55:37 -0800 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3344-1 ]]> dd-firmware (LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 24 Feb 2026 10:38:34 -0800 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=046bc2b62cf942b7e846fa5bff698b94238edf24 https://devapps.diality.us/changelog/dd-firmware?cs=046bc2b62cf942b7e846fa5bff698b94238edf24 Dara Navaei committed 046bc2b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 49 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/RinsePump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/RinsePump.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/GPIO.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/GPIO.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/FPModes/StateFlushConcentrate.c (-2, +2) | History | Source | Diff
· /firmware/App/Monitors/Level.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/FpgaDD.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/FpgaDD.h (-3, +3) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-2, +2) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-3344-1: reviewers finished Tue, 24 Feb 2026 10:35:01 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 Raghu Kallala , Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3344-1 LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates. ]]> LEAHI-DD-FIRMWARE-LDT-3344-1: started by Vendor - TEL - Jashwant Gantyada Mon, 23 Feb 2026 13:18:40 -0800 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1 Vendor - TEL - Jashwant Gantyada started review LEAHI-DD-FIRMWARE-LDT-3344-1 ]]> LEAHI-DD-FIRMWARE-LDT-3344-1: comment by Vendor - TEL - Sameer Poyil "This is total mess up . that is what I want it ..." Fri, 20 Feb 2026 14:19:23 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1/#c27522 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1/#c27522 Vendor - TEL - Sameer Poyil replied to Raghu Kallala in LEAHI-DD-FIRMWARE-LDT-3344-1

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

]]> LEAHI-DD-FIRMWARE-LDT-3344-1: comment by Vendor - TEL - Sameer Poyil "Removing all the review comments and created a ..." Fri, 20 Feb 2026 14:17:04 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1/#c27521 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3344-1/#c27521 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3344-1

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

]]>