Fisheye on leahi-dialin/leahi_dialin/fp/modules https://devapps.diality.us/changelog/~br%3DLDT-3218-update-iofp-permeate-target-flow/leahi-dialin/leahi_dialin/fp/modules Recent activity in "leahi-dialin" under directory /leahi_dialin/fp/modules LEAHI-DIALIN-LDT-3984-1: reviewers finished Mon, 27 Apr 2026 08:15:12 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1 Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3984-1 LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber ]]> LEAHI-DIALIN-LDT-3218-1: comment by Sean Nash "Should this be an enumeration somewhere?" Sun, 26 Apr 2026 14:46:25 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1/#c28685 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1/#c28685 Sean Nash commented on LEAHI-DIALIN-LDT-3218-1

Should this be an enumeration somewhere?

]]> LEAHI-DIALIN-LDT-3984-1: reviewers finished Sun, 26 Apr 2026 12:25:57 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1 Sean Nash finished reviewing LEAHI-DIALIN-LDT-3984-1 LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber ]]> LEAHI-DIALIN-LDT-3984-1: started by Dara Navaei Thu, 23 Apr 2026 08:02:29 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1 Dara Navaei started review LEAHI-DIALIN-LDT-3984-1 ]]> LEAHI-DIALIN-LDT-696-1: closed by Zoltan Miskolci Mon, 30 Mar 2026 14:33:37 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-696-1 ]]> LEAHI-DIALIN-LDT-696-1: reviewers finished Mon, 30 Mar 2026 11:30:47 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-696-1 LEAHI-DIALIN-LDT-696_[TC Implement] LVTC-13 ]]> LEAHI-DIALIN-LDT-2655-1: reviewers finished Mon, 30 Mar 2026 09:39:06 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Sean Nash finished reviewing LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]> leahi-dialin (LDT-3218-update-iofp-permeate-target-flow): LDT-3218: added valve recovery config method Thu, 26 Mar 2026 18:29:24 -0700 Michael Garthwaite https://devapps.diality.us/changelog/leahi-dialin?cs=85af425612b38183f788af2120cec58b37cf9dc3 https://devapps.diality.us/changelog/leahi-dialin?cs=85af425612b38183f788af2120cec58b37cf9dc3 Michael Garthwaite committed 85af425 on branch LDT-3218-update-iofp-permeate-target-flow, develop in leahi-dialin LDT-3218: added valve recovery config method

· /leahi_dialin/fp/modules/valves.py (-0, +28) | History | Source | Diff
]]> LEAHI-DIALIN-LDT-3218-1: started by Dara Navaei Thu, 26 Mar 2026 12:16:59 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1 Dara Navaei started review LEAHI-DIALIN-LDT-3218-1 ]]> LEAHI-DIALIN-LDT-696-1: reviewers finished Thu, 26 Mar 2026 11:16:40 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-696-1 LEAHI-DIALIN-LDT-696_[TC Implement] LVTC-13 ]]> LEAHI-DIALIN-LDT-696-1: comment by Zoltan Miskolci "Added" Thu, 26 Mar 2026 10:30:02 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28137 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28137 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-696-1

Added

]]> LEAHI-DIALIN-LDT-696-1: comment by Raghu Kallala "Add a TODO comment to change the message once i..." Thu, 26 Mar 2026 06:32:24 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28136 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28136 Raghu Kallala commented on LEAHI-DIALIN-LDT-696-1

Add a TODO comment to change the message once implemented in FW

]]> LEAHI-DIALIN-LDT-3629-2: closed by Zoltan Miskolci Mon, 23 Mar 2026 09:13:46 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3629-2 ]]> LEAHI-DIALIN-LDT-696-1: comment by Zoltan Miskolci "removed duplicate" Fri, 20 Mar 2026 14:07:24 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28128 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28128 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-696-1

removed duplicate

]]> LEAHI-DIALIN-LDT-696-1: comment by Raghu Kallala "ROPump is repeated" Fri, 20 Mar 2026 14:04:11 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28127 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28127 Raghu Kallala commented on LEAHI-DIALIN-LDT-696-1

ROPump is repeated

]]> LEAHI-DIALIN-LDT-696-1: comment by Raghu Kallala "RECOVERY_STATES" Fri, 20 Mar 2026 13:56:10 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28126 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1/#c28126 Raghu Kallala commented on LEAHI-DIALIN-LDT-696-1

RECOVERY_STATES

]]> LEAHI-DIALIN-LDT-696-1: started by Dara Navaei Fri, 20 Mar 2026 13:46:22 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-696-1 Dara Navaei started review LEAHI-DIALIN-LDT-696-1 ]]> LEAHI-DIALIN-LDT-3629-2: reviewers finished Wed, 18 Mar 2026 13:27:23 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3629-2 LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list ]]> LEAHI-DIALIN-LDT-3629-2: comment by Raghu Kallala "update params" Tue, 17 Mar 2026 07:05:16 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2/#c28079 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2/#c28079 Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-2

update params

]]> LEAHI-DIALIN-LDT-3629-2: started by Dara Navaei Mon, 16 Mar 2026 12:06:59 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-2 Dara Navaei started review LEAHI-DIALIN-LDT-3629-2 ]]> leahi-dialin (LDT-3910-td_test_conf): renamed dict keys Mon, 16 Mar 2026 11:53:00 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=d089b54d2fde7f8c36acce41a47d7acee4ef5da6 https://devapps.diality.us/changelog/leahi-dialin?cs=d089b54d2fde7f8c36acce41a47d7acee4ef5da6 Zoltan Miskolci committed d089b54 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-3218-update-iofp-permeate-target-flow and 17 more in leahi-dialin renamed dict keys

· /leahi_dialin/dd/modules/heaters.py (-1, +0) | History | Source | Diff
· /leahi_dialin/dd/modules/valves.py (-3, +3) | History | Source | Diff
· /leahi_dialin/fp/modules/valves.py (-3, +3) | History | Source | Diff
]]> LEAHI-DIALIN-LDT-2655-1: comment by Michael Garthwaite "yeah its obsolete. This is an old branch that r..." Mon, 16 Mar 2026 10:04:25 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c28052 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c28052 Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LDT-2655-1

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

]]> LEAHI-DIALIN-LDT-3629-1: closed by Zoltan Miskolci Thu, 12 Mar 2026 14:32:23 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3629-1 ]]> LEAHI-DIALIN-LDT-3629-1: reviewers finished Thu, 12 Mar 2026 14:12:47 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1 Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3629-1 LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list ]]> LEAHI-DIALIN-LDT-3629-1: comment by Zoltan Miskolci "Fixed" Thu, 12 Mar 2026 11:50:16 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27939 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27939 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

Fixed

]]> LEAHI-DIALIN-LDT-3629-1: comment by Zoltan Miskolci "added Todo comment" Thu, 12 Mar 2026 11:48:59 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27938 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27938 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

added Todo comment

]]> leahi-dialin (LDT-3910-td_test_conf): Fix for CR Thu, 12 Mar 2026 11:48:47 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=21a1d644c7d02e7588781b9025b422aa9d74c9ca https://devapps.diality.us/changelog/leahi-dialin?cs=21a1d644c7d02e7588781b9025b422aa9d74c9ca Zoltan Miskolci committed 21a1d64 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 22 more in leahi-dialin Fix for CR

· /leahi_dialin/fp/modules/fp_test_configs.py (-2, +0) | History | Source | Diff
· /leahi_dialin/fp/modules/ro_pump.py (-1, +0) | History | Source | Diff
· /leahi_dialin/td/modules/pressure_sensors.py (-0, +1) | History | Source | Diff
]]> LEAHI-DIALIN-LDT-3629-1: comment by Zoltan Miskolci "They were added while debugging fp_test_configs..." Thu, 12 Mar 2026 11:47:16 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27937 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27937 Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

They were added while debugging fp_test_configs and why it's never being updated.
Removed.

]]> LEAHI-DIALIN-LDT-3629-1: comment by Michael Garthwaite "tip: use the logger and set the statement to er..." Thu, 12 Mar 2026 10:59:15 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27936 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27936 Michael Garthwaite replied to Raghu Kallala in LEAHI-DIALIN-LDT-3629-1

tip: use the logger and set the statement to error level and you can see it in runtime

]]> LEAHI-DIALIN-LDT-3629-1: comment by Raghu Kallala "pressure limit will be unsigned int not signed ..." Thu, 12 Mar 2026 09:49:11 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27913 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3629-1/#c27913 Raghu Kallala commented on LEAHI-DIALIN-LDT-3629-1

pressure limit will be unsigned int not signed int with LDT-473..beta CR
Add a TODO to update once the 473 is ready to merge

]]>