Fisheye on leahi-dialin/leahi_dialin/common/override_templates.py

LEAHI-DIALIN-LDT-2998-1: closed by Zoltan Miskolci

Zoltan Miskolci — Mon, 26 Jan 2026 16:51:05 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-2998-1

LEAHI-DIALIN-LDT-2998-1: reviewers finished

Mon, 26 Jan 2026 16:19:28 -0800

Vendor - TEL - Varshini Nagabooshanam and Sean Nash finished reviewing LEAHI-DIALIN-LDT-2998-1

LEAHI-DIALIN-LDT-2998_Update Dialin to support any B1.9 FW and/or HW changes (higher priority)

LEAHI-DIALIN-LDT-2998-1: reviewers resumed

Fri, 23 Jan 2026 15:18:38 -0800

Michael Garthwaite resumed reviewing LEAHI-DIALIN-LDT-2998-1

LEAHI-DIALIN-LDT-2998_Update Dialin to support any B1.9 FW and/or HW changes (higher priority)

LEAHI-DIALIN-LDT-3214-1: closed by Zoltan Miskolci

Zoltan Miskolci — Thu, 22 Jan 2026 10:07:41 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214-1: reviewers finished

Wed, 21 Jan 2026 12:35:59 -0800

Sean Nash finished reviewing LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-3214-1: reviewers added to LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to u...

Wed, 21 Jan 2026 09:47:38 -0800

Zoltan Miskolci added Raghu Kallala to LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-3214-1: reviewers finished

Tue, 20 Jan 2026 15:33:25 -0800

Tiffany Mejia finished reviewing LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions

LEAHI-DIALIN-LDT-607-1: closed by Zoltan Miskolci

Zoltan Miskolci — Tue, 20 Jan 2026 08:56:37 -0800

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-607-1

LEAHI-DIALIN-LDT-607-1: reviewers finished

Tue, 20 Jan 2026 08:23:16 -0800

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-607-1

LEAHI-DIALIN-LDT-607_TD: Add command to override TMP

LEAHI-DIALIN-LDT-607-1: reviewers finished

Mon, 19 Jan 2026 11:57:57 -0800

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-607-1

LEAHI-DIALIN-LDT-607_TD: Add command to override TMP

LEAHI-DIALIN-LDT-607-1: reviewers added to LEAHI-DIALIN-LDT-607_TD: Add command to override T...

Thu, 15 Jan 2026 10:08:18 -0800

Zoltan Miskolci added Raghu Kallala to LEAHI-DIALIN-LDT-607-1

LEAHI-DIALIN-LDT-607_TD: Add command to override TMP

LEAHI-DIALIN-LDT-3214-1: comment by Zoltan Miskolci "Putting the aliases at the end makes them group..."

Zoltan Miskolci — Mon, 12 Jan 2026 17:07:56 -0800

Zoltan Miskolci replied to Sean Nash in LEAHI-DIALIN-LDT-3214-1

Putting the aliases at the end makes them grouped up and in my opinion makes easier reading of the enum.

LEAHI-DIALIN-LDT-3214-1: comment by Sean Nash "Why move this here? Seems like an odd placemen..."

Sean Nash — Mon, 12 Jan 2026 13:04:02 -0800

Sean Nash commented on LEAHI-DIALIN-LDT-3214-1

Why move this here? Seems like an odd placement so far away from D14.

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): - Removed some empty lines to have the same formating throgh the files

Zoltan Miskolci — Fri, 09 Jan 2026 11:41:12 -0800

Zoltan Miskolci committed 18c90a1 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 41 more in leahi-dialin

- Removed some empty lines to have the same formating throgh the files

· /leahi_dialin/common/fp_defs.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/common/override_templates.py

(-2, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-9, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-5, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-8, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-4, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-2, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-7, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-6, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-2, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-3, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/post_gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pre_gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

… 39 more files in changeset.

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): LDT-2787 - Added opmode change request to dd_proxy - Updated overrides in TD module

Zoltan Miskolci — Thu, 08 Jan 2026 17:42:45 -0800

Zoltan Miskolci committed 03dc6c3 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 41 more in leahi-dialin

LDT-2787 - Added opmode change request to dd_proxy - Updated overrides in TD module

· /leahi_dialin/common/override_templates.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/common/td_defs.py

(-2, +2)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-3, +6)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/alarms.py

(-41, +81)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/events.py

(-7, +14)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/fp_test_configs.py

(-86, +60)

| History

| Source

| Diff

· /leahi_dialin/td/modules/air_pump.py

(-62, +40)

| History

| Source

| Diff

· /leahi_dialin/td/modules/air_trap.py

(-153, +90)

| History

| Source

| Diff

· /leahi_dialin/td/modules/alarms.py

(-274, +149)

| History

| Source

| Diff

· /leahi_dialin/td/modules/blood_flow.py

(-254, +131)

| History

| Source

| Diff

· /leahi_dialin/td/modules/bubble_detector.py

(-68, +39)

| History

| Source

| Diff

· /leahi_dialin/td/modules/buttons.py

(-51, +29)

| History

| Source

| Diff

· /leahi_dialin/td/modules/ejector.py

(-83, +41)

| History

| Source

| Diff

· /leahi_dialin/td/modules/events.py

(-6, +14)

| History

| Source

| Diff

… 5 more files in changeset.

LEAHI-DIALIN-LDT-2998-1: comment by Zoltan Miskolci "Merged FP into DD test configs"

Zoltan Miskolci — Thu, 08 Jan 2026 10:33:30 -0800

Zoltan Miskolci replied to Vinayakam Mani in LEAHI-DIALIN-LDT-2998-1

Merged FP into DD test configs

LEAHI-DIALIN-LDT-2998-1: comment by Zoltan Miskolci "Renamed"

Zoltan Miskolci — Thu, 08 Jan 2026 10:33:13 -0800

Zoltan Miskolci replied to Vinayakam Mani in LEAHI-DIALIN-LDT-2998-1

Renamed

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): LDT-3214 - Updated description of cmd_generic_override - Updated rest of DD module files

Zoltan Miskolci — Thu, 08 Jan 2026 10:06:21 -0800

Zoltan Miskolci committed aa534fb on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 41 more in leahi-dialin

LDT-3214 - Updated description of cmd_generic_override - Updated rest of DD module files

· /leahi_dialin/common/override_templates.py	(-7, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/dialysate_delivery.py	(-52, +39)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/proxies/ro_proxy.py	(-7, +7)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-607-1: reviewers finished

Thu, 08 Jan 2026 09:44:01 -0800

Sean Nash finished reviewing LEAHI-DIALIN-LDT-607-1

LEAHI-DIALIN-LDT-607_TD: Add command to override TMP

LEAHI-DIALIN-LDT-2998-1: comment by Zoltan Miskolci "Fixed"

Zoltan Miskolci — Thu, 08 Jan 2026 09:34:16 -0800

Zoltan Miskolci replied to Vinayakam Mani in LEAHI-DIALIN-LDT-2998-1

Fixed

LEAHI-DIALIN-LDT-2998-1: comment by Zoltan Miskolci "Added enum to FP and TD Configs."

Zoltan Miskolci — Thu, 08 Jan 2026 09:34:05 -0800

Zoltan Miskolci replied to Vinayakam Mani in LEAHI-DIALIN-LDT-2998-1

Added enum to FP and TD Configs.

LEAHI-DIALIN-LDT-2998-1: comment by Zoltan Miskolci "[~vmani] What is the advantage of doing that? ..."

Zoltan Miskolci — Thu, 08 Jan 2026 09:19:01 -0800

Zoltan Miskolci replied to Vinayakam Mani in LEAHI-DIALIN-LDT-2998-1

Vinayakam Mani What is the advantage of doing that?
If I go with Beta_1_9_HW, I will need to rename the flag when we start using Beta 2+. And rename it in all the scripts in different repository when starting with 2.0.
While I use a more generic flag, I won't need to do that. So just using a better name I am sparing myself hours of work in the future.

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): LDT-3214 - Refactored DD module's override functions to use the override template functions - Removed constants file fro...

Zoltan Miskolci — Wed, 07 Jan 2026 17:32:08 -0800

Zoltan Miskolci committed 0bdafdb on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 41 more in leahi-dialin

LDT-3214 - Refactored DD module's override functions to use the override template functions - Removed constants file from DD module to use the one from common

· /leahi_dialin/common/override_templates.py

(-5, +11)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/alarms.py

(-30, +161)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-102, +55)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-172, +139)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-130, +72)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-97, +48)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/constants.py

(-21, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dd_test_configs.py

(-84, +64)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-122, +73)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/events.py

(-6, +17)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-114, +64)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-88, +65)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-43, +28)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/post_gen_dialysate.py

(-30, +18)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pre_gen_dialysate.py

(-30, +19)

| History

| Source

| Diff

… 8 more files in changeset.

LEAHI-DIALIN-LDT-2998-1: comment by Vinayakam Mani "You may use the same test configs from DD here,..."

Vinayakam Mani — Wed, 07 Jan 2026 11:46:21 -0800

Vinayakam Mani commented on LEAHI-DIALIN-LDT-2998-1

You may use the same test configs from DD here, to set the relevant test configs from FP Dialin.

LEAHI-DIALIN-LDT-2998-1: comment by Vinayakam Mani "POS_FIELD_3??"

Vinayakam Mani — Wed, 07 Jan 2026 11:35:47 -0800

Vinayakam Mani commented on LEAHI-DIALIN-LDT-2998-1

POS_FIELD_3??

LEAHI-DIALIN-LDT-2998-1: comment by Vinayakam Mani "Please follow the same naming convention as fir..."

Vinayakam Mani — Wed, 07 Jan 2026 11:34:28 -0800

Vinayakam Mani commented on LEAHI-DIALIN-LDT-2998-1

Please follow the same naming convention as firmware enums.

leahi-dialin (LDT-1195-dd-is-balancing-chamber-switching): Add missing parameter

Zoltan Miskolci — Wed, 07 Jan 2026 09:50:47 -0800

Zoltan Miskolci committed 51f7769 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 41 more in leahi-dialin

Add missing parameter

· /leahi_dialin/common/override_templates.py

(-0, +1)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-3214-1: started by Dara Navaei

Dara Navaei — Tue, 06 Jan 2026 16:33:01 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-3214-1

LEAHI-DIALIN-LDT-607-1: reviewers added to LEAHI-DIALIN-LDT-607_TD: Add command to override T...

Tue, 06 Jan 2026 16:14:41 -0800

Dara Navaei added Sean Nash to LEAHI-DIALIN-LDT-607-1

LEAHI-DIALIN-LDT-607_TD: Add command to override TMP

LEAHI-DIALIN-LDT-607-1: reviewers removed from LEAHI-DIALIN-LDT-607_TD: Add command to override T...

Tue, 06 Jan 2026 16:14:41 -0800

Dara Navaei removed Zoltan Miskolci from LEAHI-DIALIN-LDT-607-1

LEAHI-DIALIN-LDT-607_TD: Add command to override TMP