LEAHI-DIALIN-LDT-2998-1 LEAHI-DIALIN-LDT-2998_Update Dialin to support any B1.9 FW and/or HW changes (higher priority)

closed on 26 Jan

Author

Moderator

Reviewers

LEAHI-DIALIN-LDT-2998_Update Dialin to support any B1.9 FW and/or HW changes...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 23

leahi-dialin 0
- Folder leahi_dialin 0
  - Folder common 0
    - File __init__.py 0 Remove
    - File dd_defs.py 5 Remove
    - File fp_defs.py 0 Remove
    - File msg_ids.py 0 Remove
    - File override_templates.py 0 Remove
    - File test_config_defs.py 6 Remove
  - Folder dd 0
    - Folder modules 0
      - File conductivity_sensors.py 0 Remove
      - File dd_test_configs.py 0 Remove
      - File gen_dialysate.py 2 Remove
      - File levels.py 4 Remove
      - File pressure_sensors.py 0 Remove
      - File rinse_pump.py 2 Remove
      - File temperature_sensors.py 2 Remove
      - File valves.py 2 Remove
    - File __init__.py 0 Remove
  - Folder fp 0
    - Folder modules 0
      - File fp_test_configs.py 0 Remove
      - File pressure_sensors.py 0 Remove
      - File temperatures.py 0 Remove
      - File valves.py 0 Remove
    - File __init__.py 0 Remove
  - Folder protocols 0
    - File __init__.py 0 Remove
  - Folder td/modules 0
    - File ejector.py 0 Remove
  - Folder utils 0
    - File __init__.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Zoltan Miskolci	Author & Moderator	1h 15m	12	Merged FP into DD test configs
Dara Navaei	Reviewer - 19% reviewed	53h 29m	1	Match with the firmware in LDT-2998.
Behrouz NematiPour	Reviewer - 0% reviewed
Stephen Quong	Reviewer - 0% reviewed
Michael Garthwaite	Reviewer - 61% reviewed	8m
Tiffany Mejia	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 8% reviewed	54m	7	You may use the same test configs from DD here, to set th...
Sean Nash	Reviewer - Complete	19m	3	Understand. In this case, the spare positions correspond ...
Nicholas Ramirez	Reviewer - 0% reviewed
Vendor - TEL - Varshini Nagabooshanam	Reviewer - Complete	3h 45m
Total		59h 51m	23

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-DIALIN-LDT-2998-1

LEAHI-DIALIN-LDT-2998_Update Dialin to support any B1.9 FW and/or HW changes...

LEAHI-DIALIN-LDT-2998-1 23

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAHI-DIALIN-LDT-2998_Update Dialin to support any B1.9 FW and/or HW changes...

LEAHI-DIALIN-LDT-2998-1 23

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time