The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

You are right, modified in all places

FALSE?

FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

Add comment that these modes not (yet?) supported.

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

Balancing chamber switching control

remove the space before false.

Remove blank line

Remove blank line.

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

Remove blank line and comment saying we're not doing anything (because now we're doing something).

isBalChamberSwitchingOffRequested is an output.

Should we set the other switch to FALSE, just in case?

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DialysatePumps.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-6, +6)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/SpentChamberFill.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPOperationModes.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-2, +2)	| History	| Source	| Diff
… 3 more files in changeset.

]]> Tue, 10 Feb 2026 13:32:45 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3 Vendor - TEL - Sameer Poyil and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-2004-3 LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD ]]> Tue, 10 Feb 2026 11:33:08 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=8e51a0b2c665b26f2a48430c10717762c427e583 https://devapps.diality.us/changelog/dd-firmware?cs=8e51a0b2c665b26f2a48430c10717762c427e583 Vendor - TEL - Sameer Poyil committed 8e51a0b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 44 more in dd-firmware LDT-2004-3 Dry bicart review comments implementation

· /firmware/App/Controllers/BalancingChamber.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-1, +1)	| History	| Source	| Diff

]]> Tue, 10 Feb 2026 10:50:36 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3/#c27156 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3/#c27156 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-3

Add TODO to comment.