Fisheye on leahi-dialin/leahi_dialin/fp

LEAHI-DIALIN-LDT-3218-1: comment by Sean Nash "Should this be an enumeration somewhere?"

Sean Nash — Sun, 26 Apr 2026 14:46:25 -0700

Sean Nash commented on LEAHI-DIALIN-LDT-3218-1

Should this be an enumeration somewhere?

LEAHI-DIALIN-LDT-3984-1: reviewers finished

Sun, 26 Apr 2026 12:25:57 -0700

Sean Nash finished reviewing LEAHI-DIALIN-LDT-3984-1

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber

LEAHI-DIALIN-LDT-3984-1: started by Dara Navaei

Dara Navaei — Thu, 23 Apr 2026 08:02:29 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3984-1

LEAHI-DIALIN-LDT-3910-1: closed by Zoltan Miskolci

Zoltan Miskolci — Fri, 10 Apr 2026 10:20:46 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3910-1

LEAHI-DIALIN-LDT-3910-1: reviewers finished

Thu, 09 Apr 2026 15:20:39 -0700

Raghu Kallala and Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3910-1

LEAHI-DIALIN-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode

LEAHI-DIALIN-LDT-3910-1: started by Dara Navaei

Dara Navaei — Thu, 09 Apr 2026 15:00:53 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3910-1

LEAHI-DIALIN-LDT-3824-1: closed by Zoltan Miskolci

Zoltan Miskolci — Wed, 08 Apr 2026 11:26:38 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3824-1

LEAHI-DIALIN-LDT-3824-1: reviewers finished

Wed, 08 Apr 2026 10:01:06 -0700

Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3824-1

LEAHI-DIALIN-LDT-3824_[Leahi-TestCommon] Enhance state machine

leahi-dialin (LDT-3910-td_test_conf): CR fixes

Zoltan Miskolci — Wed, 08 Apr 2026 09:52:02 -0700

Zoltan Miskolci committed 3501d50 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-3352-dd---revisit-d3-level-control-l and 9 more in leahi-dialin

CR fixes

· /leahi_dialin/fp/filtration_purification.py

(-3, +3)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-3824-1: comment by Raghu Kallala "Typo, response"

Raghu Kallala — Wed, 08 Apr 2026 09:48:10 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-3824-1

Typo, response

LEAHI-DIALIN-LDT-3824-1: comment by Raghu Kallala "Typo, response"

Raghu Kallala — Wed, 08 Apr 2026 09:48:05 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-3824-1

Typo, response

LEAHI-DIALIN-LDT-3824-1: comment by Raghu Kallala "Fix the header"

Raghu Kallala — Wed, 08 Apr 2026 09:47:24 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-3824-1

Fix the header

leahi-dialin (LDT-3910-td_test_conf): enum updates

Zoltan Miskolci — Thu, 02 Apr 2026 11:13:12 -0700

Zoltan Miskolci committed c6b28ca on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-3352-dd---revisit-d3-level-control-l and 9 more in leahi-dialin

enum updates

· /leahi_dialin/common/dd_defs.py	(-19, +197)	\| History	\| Source	\| Diff
· /leahi_dialin/common/dd_defs_proxy.py	(-2, +19)	\| History	\| Source	\| Diff
· /leahi_dialin/common/disp_defs.py	(-0, +84)	\| History	\| Source
· /leahi_dialin/common/disp_defs_proxy.py	(-0, +26)	\| History	\| Source
· /leahi_dialin/common/fp_defs.py	(-1, +106)	\| History	\| Source	\| Diff
· /leahi_dialin/common/fp_defs_proxy.py	(-0, +14)	\| History	\| Source	\| Diff
· /leahi_dialin/common/msg_ids.py	(-0, +3)	\| History	\| Source	\| Diff
· /leahi_dialin/common/td_defs.py	(-106, +560)	\| History	\| Source	\| Diff
· /leahi_dialin/common/td_defs_proxy.py	(-38, +72)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/filtration_purification.py	(-7, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/ejector.py	(-1, +1)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-3824-1: started by Dara Navaei

Dara Navaei — Tue, 31 Mar 2026 10:32:37 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3824-1

LEAHI-DIALIN-LDT-696-1: closed by Zoltan Miskolci

Zoltan Miskolci — Mon, 30 Mar 2026 14:33:37 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-696-1

LEAHI-DIALIN-LDT-696-1: reviewers finished

Mon, 30 Mar 2026 11:30:47 -0700

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-696-1

LEAHI-DIALIN-LDT-696_[TC Implement] LVTC-13

LEAHI-DIALIN-LDT-2655-1: reviewers finished

Mon, 30 Mar 2026 09:39:06 -0700

Sean Nash finished reviewing LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-3218-1: started by Dara Navaei

Dara Navaei — Thu, 26 Mar 2026 12:16:59 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3218-1

LEAHI-DIALIN-LDT-696-1: reviewers finished

Thu, 26 Mar 2026 11:16:40 -0700

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-696-1

LEAHI-DIALIN-LDT-696_[TC Implement] LVTC-13

leahi-dialin (LDT-3910-td_test_conf): moved comment

Zoltan Miskolci — Thu, 26 Mar 2026 10:31:05 -0700

Zoltan Miskolci committed dd2124b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-3352-dd---revisit-d3-level-control-l and 11 more in leahi-dialin

moved comment

· /leahi_dialin/fp/filtration_purification.py

(-2, +1)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-696-1: comment by Zoltan Miskolci "Added"

Zoltan Miskolci — Thu, 26 Mar 2026 10:30:02 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-696-1

Added

leahi-dialin (LDT-3910-td_test_conf): Added todo comments

Zoltan Miskolci — Thu, 26 Mar 2026 10:29:01 -0700

Zoltan Miskolci committed 446eae0 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-3352-dd---revisit-d3-level-control-l and 11 more in leahi-dialin

Added todo comments

· /leahi_dialin/fp/filtration_purification.py

(-4, +5)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-696-1: comment by Raghu Kallala "Add a TODO comment to change the message once i..."

Raghu Kallala — Thu, 26 Mar 2026 06:32:24 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-696-1

Add a TODO comment to change the message once implemented in FW

leahi-dialin (LDT-3910-td_test_conf): - Fixes fp pump status enums - P40 template

Zoltan Miskolci — Wed, 25 Mar 2026 15:20:06 -0700

Zoltan Miskolci committed fd6f015 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-3352-dd---revisit-d3-level-control-l and 11 more in leahi-dialin

- Fixes fp pump status enums - P40 template

· /leahi_dialin/common/fp_defs.py	(-10, +10)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/filtration_purification.py	(-13, +48)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-3629-2: closed by Zoltan Miskolci

Zoltan Miskolci — Mon, 23 Mar 2026 09:13:46 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3629-2

LEAHI-DIALIN-LDT-696-1: comment by Zoltan Miskolci "removed duplicate"

Zoltan Miskolci — Fri, 20 Mar 2026 14:07:24 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-696-1

removed duplicate

LEAHI-DIALIN-LDT-696-1: comment by Raghu Kallala "ROPump is repeated"

Raghu Kallala — Fri, 20 Mar 2026 14:04:11 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-696-1

ROPump is repeated

LEAHI-DIALIN-LDT-696-1: comment by Raghu Kallala "RECOVERY_STATES"

Raghu Kallala — Fri, 20 Mar 2026 13:56:10 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-696-1

RECOVERY_STATES

LEAHI-DIALIN-LDT-696-1: started by Dara Navaei

Dara Navaei — Fri, 20 Mar 2026 13:46:22 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-696-1

leahi-dialin (LDT-3910-td_test_conf): - Added RO recovery enum - Updated FP Pump state enums

Zoltan Miskolci — Fri, 20 Mar 2026 13:31:06 -0700

Zoltan Miskolci committed 99f9233 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-3352-dd---revisit-d3-level-control-l and 11 more in leahi-dialin

- Added RO recovery enum - Updated FP Pump state enums

· /leahi_dialin/common/dd_defs_proxy.py	(-41, +41)	\| History	\| Source	\| Diff
· /leahi_dialin/common/fp_defs.py	(-7, +47)	\| History	\| Source	\| Diff
· /leahi_dialin/common/fp_defs_proxy.py	(-30, +33)	\| History	\| Source	\| Diff
· /leahi_dialin/common/td_defs_proxy.py	(-39, +39)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/boost_pump.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/ro_pump.py	(-1, +1)	\| History	\| Source	\| Diff