Fisheye on dd-firmware/firmware/App/Modes/ModeGenDialysate.c

Fisheye on dd-firmware/firmware/App/Modes/ModeGenDialysate.c https://devapps.diality.us/changelog/~br%3DLDT-3928-fw-implementation-fp-boost-pump/dd-firmware/firmware/App/Modes/ModeGenDialysate.c Recent activity in "dd-firmware" under directory /firmware/App/Modes/ModeGenDialysate.c LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conduc... Thu, 23 Apr 2026 14:59:17 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "instead of 0, we can use the level Enum 'LVL_ST..." Thu, 23 Apr 2026 14:56:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "lower? and change the D98 level sensor comment ..." Thu, 23 Apr 2026 14:49:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

lower? and change the D98 level sensor comment as well.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Remove empty line" Thu, 23 Apr 2026 14:47:11 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove empty line

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space before LVL_STATE_LOW" Thu, 23 Apr 2026 14:45:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space before LVL_STATE_LOW

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "space inside array index." Thu, 23 Apr 2026 14:43:35 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

space inside array index.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space inside parenthesis." Thu, 23 Apr 2026 14:41:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space inside parenthesis.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Change this to LEVEL_T enum." Thu, 23 Apr 2026 14:39:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Change this to LEVEL_T enum.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Is this macro still being used? if not, delete ..." Thu, 23 Apr 2026 14:38:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Is this macro still being used? if not, delete it.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: started by Dara Navaei Thu, 23 Apr 2026 07:47:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3978-1 ]]> LEAHI-DD-FIRMWARE-LDT-3749-2: closed by Raghu Kallala Wed, 22 Apr 2026 10:41:20 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3749-2 ]]> LEAHI-DD-FIRMWARE-LDT-3749-2: reviewers finished Wed, 22 Apr 2026 09:55:43 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3749-2 LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem ]]> LEAHI-DD-FIRMWARE-LDT-3749-2: reviewers finished Tue, 21 Apr 2026 14:17:37 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3749-2 LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem ]]> LEAHI-DD-FIRMWARE-LDT-3749-2: comment by Raghu Kallala "Updated" Tue, 21 Apr 2026 08:34:00 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28558 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28558 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3749-2

Updated

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: closed by Vinayakam Mani Fri, 17 Apr 2026 09:54:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Vinayakam Mani Closed LEAHI-DD-FIRMWARE-LDT-3352-1 ]]> LEAHI-DD-FIRMWARE-LDT-3352-1: reviewers finished Tue, 14 Apr 2026 19:47:34 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Sean Nash and Vendor - TEL - Sameer Poyil finished reviewing LEAHI-DD-FIRMWARE-LDT-3352-1 LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic ]]> LEAHI-DD-FIRMWARE-LDT-1195-2: closed by Vendor - TEL - Arpita Srivastava Tue, 14 Apr 2026 10:57:43 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 Vendor - TEL - Arpita Srivastava Closed LEAHI-DD-FIRMWARE-LDT-1195-2 ]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Yes, this needs to be corrected. I don't see an..." Mon, 13 Apr 2026 14:58:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28299 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28299 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Since feedforward output is same as control sig..." Mon, 13 Apr 2026 11:58:50 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28297 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28297 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Reduced gain and testing in progress." Mon, 13 Apr 2026 11:57:38 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28296 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28296 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Reduced gain and testing in progress.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Reduced gain and testing in progress." Mon, 13 Apr 2026 11:57:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28295 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28295 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Reduced gain and testing in progress.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Mon, 13 Apr 2026 11:56:28 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28294 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28294 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Mon, 13 Apr 2026 11:56:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28293 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28293 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3103-3: closed by Vendor - TEL - Jashwant Gantyada Fri, 10 Apr 2026 15:01:42 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-3 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-3 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3103-3 ]]> dd-firmware (LDT-3749-ability-to-set-operation-sub-mode-latest): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 10 Apr 2026 13:47:59 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=a569e34b86e389ce6d6f4c971ea86d2690dbaaed https://devapps.diality.us/changelog/dd-firmware?cs=a569e34b86e389ce6d6f4c971ea86d2690dbaaed Dara Navaei committed a569e34 on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-2008-v2-conductivity-sensors-CLEAN and 14 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c (-1, +1) | History | Source | Diff

· /firmware/App/Modes/ModeGenDialysate.c (-1, +1) | History | Source | Diff

· /firmware/App/Modes/ModeGenDialysate.h (-1, +1) | History | Source | Diff

]]> LEAHI-DD-FIRMWARE-LDT-3103-3: reviewers finished Fri, 10 Apr 2026 13:42:50 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-3 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-3 Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3103-3 LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed ]]> dd-firmware (LDT-3749-ability-to-set-operation-sub-mode-latest): LDT-3103 merged latest staging and resolved merge conflicts Fri, 10 Apr 2026 13:30:29 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/changelog/dd-firmware?cs=75a7ea5d2216638f9abec84d92a08eebe22d5a94 https://devapps.diality.us/changelog/dd-firmware?cs=75a7ea5d2216638f9abec84d92a08eebe22d5a94 Vendor - TEL - Jashwant Gantyada committed 75a7ea5 on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-2008-v2-conductivity-sensors-CLEAN and 15 more in dd-firmware LDT-3103 merged latest staging and resolved merge conflicts

· /firmware/App/Controllers/BalancingChamber.c (-23, +218) | History | Source | Diff

· /firmware/App/Modes/ModeGenDialysate.c (-11, +21) | History | Source | Diff

]]> LEAHI-DD-FIRMWARE-LDT-3749-2: comment by Vinayakam Mani "The FP signals are not included in the DD-pre g..." Fri, 10 Apr 2026 11:44:22 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28291 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28291 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3749-2

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

]]> dd-firmware (LDT-3749-ability-to-set-operation-sub-mode-latest): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 10 Apr 2026 11:44:35 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=6d0bd19fb192dcd272fa773e8833862cc8a8f750 https://devapps.diality.us/changelog/dd-firmware?cs=6d0bd19fb192dcd272fa773e8833862cc8a8f750 Dara Navaei committed 6d0bd19 on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-2008-v2-conductivity-sensors-CLEAN and 15 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c (-2, +2) | History | Source | Diff

· /firmware/App/Controllers/BalancingChamber.h (-2, +2) | History | Source | Diff

· /firmware/App/Modes/ModeFault.c (-2, +2) | History | Source | Diff

· /firmware/App/Modes/ModeGenDialysate.c (-2, +2) | History | Source | Diff

· /firmware/App/Modes/ModeInitPOST.c (-2, +2) | History | Source | Diff

· /firmware/App/Modes/ModePostGenDialysate.c (-2, +2) | History | Source | Diff

· /firmware/App/Modes/ModePreGenDialysate.c (-2, +2) | History | Source | Diff

· /firmware/App/Modes/ModeService.c (-2, +2) | History | Source | Diff

· /firmware/App/Modes/ModeStandby.c (-2, +2) | History | Source | Diff

· /firmware/App/Tasks/TaskGeneral.c (-2, +2) | History | Source | Diff

]]> LEAHI-DD-FIRMWARE-LDT-1195-2: reviewers finished Fri, 10 Apr 2026 11:38:33 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-1195-2 LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F) ]]>