This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

Please add HDF Pump speed register and add a monitor in the substitution pump controller to compare against the target speed and if the difference is out of range, trigger an alarm.

Substitution pump

Missing comment.

update comment. next one as well.

blank line after the banner and maintain alphabetical order of include files.

· /firmware/App/Controllers/BalancingChamber.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/BloodLeakDriver.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivityTeensy.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-2, +2)	| History	| Source	| Diff
… 4 more files in changeset.

]]> Fri, 22 May 2026 11:11:01 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3963-1 ]]> Fri, 22 May 2026 10:50:41 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3963-1 LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3: ]]> Fri, 22 May 2026 09:05:04 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/changelog/dd-firmware?cs=0253afcc2b02def4d57a4a21a20a9b3a6fe65f22 https://devapps.diality.us/changelog/dd-firmware?cs=0253afcc2b02def4d57a4a21a20a9b3a6fe65f22 Vendor - TEL - Jashwant Gantyada committed 0253afc on branch LDT-3272-software-update---dd-firmware, LDT-3958-dialysate-temperature---fw-impl and 6 more in dd-firmware Merge branch 'staging' into feature/LDT-3963-dialysate-flow-rate---fw-implem

· /firmware/App/Controllers/RinsePump.c	(-15, +24)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-1, +1)	| History	| Source	| Diff

]]> Thu, 21 May 2026 15:24:19 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29309 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29309 Vendor - TEL - Jashwant Gantyada replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3963-1

restored

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Should be #ifndef

Should be #ifndef I think.

Can we make these low priority and 999 rank?

· /firmware/App/Controllers/RinsePump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPOperationModes.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeate.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c	(-1, +1)	| History	| Source	| Diff

]]> Tue, 19 May 2026 17:50:18 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4413-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4413-1 Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-4413-1 LEAHI-DD-FIRMWARE-LDT-4413_Synchronize the Change events content ]]> Tue, 19 May 2026 14:19:16 -0700 Raghu Kallala https://devapps.diality.us/changelog/dd-firmware?cs=14998cd05a5b439a1e4a01ab11ad5e65c259ee3c https://devapps.diality.us/changelog/dd-firmware?cs=14998cd05a5b439a1e4a01ab11ad5e65c259ee3c Raghu Kallala committed 14998cd on branch LDT-3272-software-update---dd-firmware, LDT-3958-dialysate-temperature---fw-impl and 9 more in dd-firmware Fixed broadcast issue for rinse pump PWM

· /firmware/App/Controllers/RinsePump.c

(-6, +10)

| History

| Source

| Diff

]]> Mon, 18 May 2026 14:59:30 -0700 Raghu Kallala https://devapps.diality.us/changelog/dd-firmware?cs=acac329c455014a27d247538bce6717a76e9c76c https://devapps.diality.us/changelog/dd-firmware?cs=acac329c455014a27d247538bce6717a76e9c76c Raghu Kallala committed acac329 on branch LDT-3272-software-update---dd-firmware, LDT-3958-dialysate-temperature---fw-impl and 9 more in dd-firmware LDT-4414 added fix to update the pwm value in broadcast and changed setpwm from count to percentage

· /firmware/App/Controllers/RinsePump.c

(-10, +15)

| History

| Source

| Diff

]]> Sun, 17 May 2026 23:33:51 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29160 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29160 Sean Nash replied to Vendor - TEL - Jashwant Gantyada in LEAHI-DD-FIRMWARE-LDT-3963-1

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

Details looks weird. Where is inputs and outputs like other function headers?

Add a blank line after banner.

Please restore before you merge to staging.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).