· /firmware/App/Controllers/DryBiCart.c

(-1, +1)

| History

| Source

| Diff

]]> Thu, 30 Apr 2026 14:23:11 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-3978-1 ]]> Thu, 30 Apr 2026 13:57:01 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=2d295ca85f19e95da42476a57ca6b4496baf980a https://devapps.diality.us/changelog/dd-firmware?cs=2d295ca85f19e95da42476a57ca6b4496baf980a Dara Navaei committed 2d295ca on branch LDT-3978-fix-for-bicart-upper-threshold-pressure, LDT-3978-fix-for-level-sensor-broadcast-data and 4 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/PermeateTank.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushConcentrate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff

]]> Thu, 30 Apr 2026 13:42:36 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> Thu, 30 Apr 2026 11:17:21 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=158684426a4bd277a7b21626393eb6f41e705165 https://devapps.diality.us/changelog/dd-firmware?cs=158684426a4bd277a7b21626393eb6f41e705165 Vendor - TEL - Sameer Poyil committed 1586844 on branch LDT-3978-fix-for-bicart-upper-threshold-pressure, LDT-3978-fix-for-level-sensor-broadcast-data and 5 more in dd-firmware LDT-3978 addressed review comments

· /firmware/App/Controllers/DryBiCart.c

(-2, +15)

| History

| Source

| Diff

]]> Thu, 30 Apr 2026 10:58:33 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28761 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28761 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3978-1

a time out for decaying D66 pressure to 3 PSI after D65 closed

· /firmware/App/Controllers/DryBiCart.c

(-14, +24)

| History

| Source

| Diff

]]> Thu, 30 Apr 2026 10:41:26 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28756 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28756 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

remove space after <= and add space end of function call.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

if we are not checking level, this can be removed and function name also can be updated accordingly.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

can we get 'runPIController' inside deadband control check?

· /firmware/App/Controllers/DryBiCart.c

(-1, +0)

| History

| Source

| Diff

]]> Thu, 30 Apr 2026 08:25:14 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=119b0ed8343d2d739ead1647360aa2f423283ddc https://devapps.diality.us/changelog/dd-firmware?cs=119b0ed8343d2d739ead1647360aa2f423283ddc Vendor - TEL - Sameer Poyil committed 119b0ed on branch LDT-3978-fix-for-bicart-upper-threshold-pressure, LDT-3978-fix-for-level-sensor-broadcast-data and 5 more in dd-firmware LDT-3978 addressing review comments

· /firmware/App/Controllers/DryBiCart.c	(-55, +60)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-8, +8)	| History	| Source	| Diff

]]> Wed, 29 Apr 2026 17:41:17 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=96468474a209ba55660ba0f1c7441bb381d24ff8 https://devapps.diality.us/changelog/dd-firmware?cs=96468474a209ba55660ba0f1c7441bb381d24ff8 Vendor - TEL - Sameer Poyil committed 9646847 on branch LDT-3978-fix-for-bicart-upper-threshold-pressure, LDT-3978-fix-for-level-sensor-broadcast-data and 5 more in dd-firmware LDT-3978 fixing compilation error

· /firmware/App/Controllers/DryBiCart.c	(-37, +103)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-1, +2)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-1, +1)	| History	| Source	| Diff

]]> Wed, 29 Apr 2026 13:36:22 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=d2f5fe93cb4abd8bf8c3bc4a9aa17146c7414062 https://devapps.diality.us/changelog/dd-firmware?cs=d2f5fe93cb4abd8bf8c3bc4a9aa17146c7414062 Vendor - TEL - Sameer Poyil committed d2f5fe9 on branch LDT-3978-fix-for-bicart-upper-threshold-pressure, LDT-3978-fix-for-level-sensor-broadcast-data and 5 more in dd-firmware LDT-3978 fix for compilation error

· /firmware/App/Controllers/DryBiCart.c

(-4, +6)

| History

| Source

| Diff

]]> Wed, 29 Apr 2026 12:25:40 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-3980-1 ]]> Wed, 29 Apr 2026 12:24:14 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=9e145b824b15215371d2b178a405ba1ae8491636 https://devapps.diality.us/changelog/dd-firmware?cs=9e145b824b15215371d2b178a405ba1ae8491636 Dara Navaei committed 9e145b8 on branch LDT-3978-fix-for-bicart-upper-threshold-pressure, LDT-3978-fix-for-level-sensor-broadcast-data and 5 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DryBiCart.c

(-1, +1)

| History

| Source

| Diff

]]> Wed, 29 Apr 2026 12:16:39 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=b4646f21bc25be3772ad436ca3abd4c23adf5166 https://devapps.diality.us/changelog/dd-firmware?cs=b4646f21bc25be3772ad436ca3abd4c23adf5166 Vendor - TEL - Sameer Poyil committed b4646f2 on branch LDT-3978-fix-for-bicart-upper-threshold-pressure, LDT-3978-fix-for-level-sensor-broadcast-data and 5 more in dd-firmware Merge branch LDT-3980-dialysate-composition-dry-bicarb---fw-impl into staging

· /firmware/App/Controllers/DryBiCart.c

(-3, +12)

| History

| Source

| Diff

]]> Wed, 29 Apr 2026 12:14:31 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3980-1 LEAHI-DD-FIRMWARE-LDT-3980_Dialysate Composition - FW Implementation (Dry Bicarbonate) - 1/1: ]]> Wed, 29 Apr 2026 11:58:57 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=38bd1e730e26416b1b11416dc8cd10e67835d067 https://devapps.diality.us/changelog/dd-firmware?cs=38bd1e730e26416b1b11416dc8cd10e67835d067 Vendor - TEL - Sameer Poyil committed 38bd1e7 on branch LDT-3978-fix-for-bicart-upper-threshold-pressure, LDT-3978-fix-for-level-sensor-broadcast-data and 6 more in dd-firmware LDT-3980 addressed review comments

· /firmware/App/Controllers/DryBiCart.c

(-0, +2)

| History

| Source

| Diff

]]> Wed, 29 Apr 2026 10:16:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28744 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28744 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3980-1

Initialize the 'dryBicartPersistantStartTime' back to zero after timeout done, for the next iterations.

· /firmware/App/Controllers/DryBiCart.c

(-3, +10)

| History

| Source

| Diff

]]> Tue, 28 Apr 2026 21:41:23 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28734 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28734 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3980-1

Nope. Since we are here after level is LOW (fill request from balancing chamber control state machine) and not filled yet. So level is still LOW

· /firmware/App/Controllers/BalancingChamber.c	(-7, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-87, +77)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-3, +0)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.h	(-4, +4)	| History	| Source	| Diff

]]> Tue, 28 Apr 2026 11:11:21 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28727 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28727 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Do we need to check if bicarb chamber level is high, ignore opening D80?

This doesn't seem to be correct. Persistence should start once fill complete pressure is achieved, not after D65 opening?

Align comment