dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove empty line

Remove empty line

Remove unused header files.

Remove unused header files.

Remove empty line.

Remove empty line.

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

Initialize result to open loop state and remove the open loop state assignment later.

Initialize result to open loop state and remove the open loop state assignment later.

Remove the blank line

Remove the blank line

Add headers for all below functions.

Add headers for all below functions.

Rmove extra blank line

Rmove extra blank line

Update Input section: Balancing chamber state

Update Input section: Balancing chamber state

We can keep it as handler instead of exec since this is being invoked from execMixingControl.

We can keep it as handler instead of exec since this is being invoked from execMixingControl.

we should use get balancing chamber fill volume if balancing chamber volume been adjusted by calibration (not an immediate need, but good to have)

we should use get balancing chamber fill volume if balancing chamber volume been adjusted by calibration (not an immediate need, but good to have)

remove min in the comment.

remove min in the comment.

Remove the unused header file.

Remove the unused header file.

Remove the unused header file.

Remove the unused header file.

Update state name matching handler name.

Update state name matching handler name.

Same as above.

Same as above.

The second condition( fill request) should be checked against true?

The second condition( fill request) should be checked against true?

Is this normal UF volume or normal UF volume + Iso UF Volume?

Is this normal UF volume or normal UF volume + Iso UF Volume?

Consider moving this validity check into the setTDRequestedGenDState function. And what should we do if it's not valid?

Consider moving this validity check into the setTDRequestedGenDState function.
And what should we do if it's not valid?

Why only these states are valid?

Why only these states are valid?

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again. we need to maintain the pressure balance in chamber F

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again.
we need to maintain the pressure balance in chamber F

will address it in new file created for mixing

will address it in new file created for mixing

fixed thanks

fixed thanks

Should we change msg ID from speed to rate?

Should we change msg ID from speed to rate?

fixed thanks

fixed thanks